Use real value when calculating OutputGroup value
ClosedPublic
Actions

Authored by PiRK on Sep 9 2021, 13:42.

Details

Reviewers

majcosta

Group Reviewers

Restricted Project

Commits

rABC01e27ccd5146: Use real value when calculating OutputGroup value

Summary

OutputGroup::m_value is the true value, not the effective value,
so use the true values of the outputs, not their effective values.

This is a backport of core#17458 [1/2]
https://github.com/bitcoin/bitcoin/pull/17458/commits/9adc2f80fc14f11ee2b1f989ee7be71b58481e6f#

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16609
Build 33073: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 33072: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 9 2021, 13:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 9 2021, 13:42

PiRK requested review of this revision.Sep 9 2021, 13:42

teamcity edited the summary of this revision. (Show Details)Sep 9 2021, 13:43

Harbormaster completed remote builds in B16609: Diff 29880.Sep 9 2021, 13:56

majcosta accepted this revision.Sep 9 2021, 18:21

This revision is now accepted and ready to land.Sep 9 2021, 18:21

Closed by commit rABC01e27ccd5146: Use real value when calculating OutputGroup value (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhySep 10 2021, 10:11

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC01e27ccd5146: Use real value when calculating OutputGroup value.

Revision Contents
Changeset List

Path

Size

src/

wallet/

coinselection.cpp

4 lines

Diff 29880

View Options

src/wallet/coinselection.cpp

Use real value when calculating OutputGroup valueClosedPublicActions