Page MenuHomePhabricator

doc: Add best practice for annotating/asserting locks
ClosedPublic

Authored by PiRK on Sep 20 2021, 10:32.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCac7014aca8fb: doc: Add best practice for annotating/asserting locks
Summary

Backport note: I removed the paragraph about LockAssertion, because the code example causes a false positive linter error, and this paragraph would anyway get removed anyway in a few commits (D10173)

This is a backport of core#19668 [5/5]
https://github.com/bitcoin/bitcoin/pull/19668/commits/ea74e10acf17903e44c85e3678853414653dd4e1

Test Plan

proofreading

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16737
Build 33324: Build Diff
Build 33323: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Sep 20 2021, 10:32
doc/developer-notes.md
795 ↗(On Diff #30075)

The linter error is a false positive

PiRK edited the summary of this revision. (Show Details)

remove the example that causes a linter error, as it would get removed anyway when backporting core#19979

This revision is now accepted and ready to land.Sep 22 2021, 07:12