Do not pass chain params to CheckForStaleTipAndEvictPeers twice
ClosedPublic
Actions

Authored by PiRK on Sep 24 2021, 12:21.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC5bc1e2c854ba: Do not pass chain params to CheckForStaleTipAndEvictPeers twice

Summary

PeerManager already keeps a reference to the chain params as a member
variable. No need to pass it in once again as a function parameter.

This is a backport of core#19914

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr19914

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16777
Build 33404: Build Diff	lint-circular-dependencies · build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 33403: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 24 2021, 12:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2021, 12:21

PiRK requested review of this revision.Sep 24 2021, 12:21

teamcity edited the summary of this revision. (Show Details)Sep 24 2021, 12:21

Harbormaster completed remote builds in B16777: Diff 30156.Sep 24 2021, 12:32

deadalnix requested changes to this revision.Sep 24 2021, 19:39

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/test/denialofservice_tests.cpp
192	Why did you change this?

This revision now requires changes to proceed.Sep 24 2021, 19:39

I favored the solution that brings the code closer to Core's codebase , because I have not preference either way and it makes future backports a bit easier.
I can change it back.

revert unnecessary changes in denialofservice_tests.cpp

Harbormaster completed remote builds in B16784: Diff 30167.Sep 27 2021, 06:45

deadalnix accepted this revision.Sep 27 2021, 21:57

This revision is now accepted and ready to land.Sep 27 2021, 21:57

Closed by commit rABC5bc1e2c854ba: Do not pass chain params to CheckForStaleTipAndEvictPeers twice (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhySep 28 2021, 07:52

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5bc1e2c854ba: Do not pass chain params to CheckForStaleTipAndEvictPeers twice.