T1904
Workflow used
- npm uninstall prettier [verify it's removed from package.json]
- npm i -g prettier [installs the latest version]
- cd web/
- prettier write .
Differential D10354
[Cashtab] Remove Prettier from dependency tree and align formatting in Web folder emack on Oct 15 2021, 00:03. Authored by
Details
T1904 Workflow used
Diff Detail
Event Timeline
Comment Actions Please run prettier --write . in the web/ folder to see if any changes come up If none come up, then just abandon this diff. We'll bump the prettier version later on in a diff that upgrades the dependency tree. If earlier whitespace removal was from IDE -- it's fine to do a diff that removes all the extra whitespace from cashtab, but then the diff should be focused on that. Comment Actions Executed prettier --write . in the web/ folder and here are the files modified in place Comment Actions I'm sorry none of this makes sense. If you run prettier int he web folder, without the original package change, you get the same result, right? Because you system's prettier is upgraded to 2.4.1, and this has nothing to do with the original change from this patch. It's fine to upgrade prettier, but this whole thing just doesn't make sense. I don't know how or why prettier ended up in that package.json and if it is even useful to have it there, but when one stumble on bullshit of the kind, the right path forward to get it sorted out, not to add a second layer of shit on top it. Comment Actions To your point @deadalnix yeah, it doesn't make sense to have prettier in the actual repo, this is an older oversight. I directed @emack to upgrade it without considering this. Intent of this diff is to just get all of the new formatting rules of the latest version of prettier applied across the whole web/ folder in one diff. That way, if new devs try to contribute to the repo and just have the latest version installed, we won't see occasional formatting differences come in that are not relevant to whatever diff they are working on. So I think path fwd from here is
Comment Actions Checking this again -- the package-lock.json file should also be updated. To remove prettier, run npm uninstall prettier from the web/cashtab folder Comment Actions To prevent users with older versions continuing to experience the same issue, add this line to the prettier object of the .arclint file in the top level of the repo "version":">=2.4.1", |