Page MenuHomePhabricator
Differential D10386

[Cashtab] Styling Update
ClosedPublic
Actions

Authored by kieran709 on Oct 22 2021, 14:46.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC992c9fc7d6a7: [Cashtab] Styling Update
Summary

updated several components based on input from community member. Related to task T1902

Test Plan

navigate to cash tab app
npm start
review style changes

Diff Detail

Repository
rABC Bitcoin ABC
Branch
CSS-Updates
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17138
Build 34107: Build Diffcashtab-tests
Build 34106: arc lint + arc unit

Event Timeline

kieran709 created this revision.Oct 22 2021, 14:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2021, 14:46
kieran709 requested review of this revision.Oct 22 2021, 14:46
Harbormaster completed remote builds in B17111: Diff 30653.Oct 22 2021, 14:49
teamcity added a comment.Oct 22 2021, 14:49
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG esZxys"
+       className="sc-jzJRlG dWXZEC"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:36:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG esZxys"
+       className="sc-jzJRlG dWXZEC"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:49:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG esZxys"
+       className="sc-jzJRlG dWXZEC"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:62:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -43,11 +43,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG esZxys"
+       className="sc-jzJRlG dWXZEC"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:75:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
      <a
        href="/send-token/bd1acc4c986de57af8d6d2a64aecad8c30ee80f37ae9d066d758923732ddc9ba"
        onClick={[Function]}
      >
        <div
-         className="sc-jKJlTe gnEvYb"
+         className="sc-jKJlTe dOjZdK"
        >
          <div
            className="sc-dxgOiQ ehOwnn"
          >
            <img
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:96:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field

kieran709 updated this revision to Diff 30654.Oct 22 2021, 14:57

updated snapshots

Harbormaster completed remote builds in B17112: Diff 30654.Oct 22 2021, 15:00
bytesofman requested changes to this revision.Oct 28 2021, 22:16

Looking good. Taking account the above comments, I think we'll go with this.

web/cashtab/src/components/App.js
57 ↗(On Diff #30654)

good catch -- in general, this type of bug fix should be its own diff.

Create a new diff from master called "patching css bug" that does nothing but adds this semi-colon here (and in the extension version of App.js if it's duplicated there)

Easy green easy diff, then rebase this to master.

Each diff should only contain changes specifically related to that diff. So this is an important workflow in general. It happens a lot where we find easy-ish bugs that happen to be geographically relevant to a given diff, but are not really part of the same problem.

web/cashtab/src/components/Common/QRCode.js
20 ↗(On Diff #30654)

was path:first-child { removed intentionally from before the fill line?

This revision now requires changes to proceed.Oct 28 2021, 22:16
kieran709 updated this revision to Diff 30695.Oct 28 2021, 23:01

responding to review feedback

teamcity added a comment.Oct 28 2021, 23:09
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG dWXZEC"
+       className="sc-jzJRlG dYsuyj"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:36:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG dWXZEC"
+       className="sc-jzJRlG dYsuyj"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:49:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 1

@@ -61,11 +61,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG dWXZEC"
+       className="sc-jzJRlG dYsuyj"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:62:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens and state field ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens and state field 1`

- Snapshot  - 1
+ Received  + 1

@@ -43,11 +43,11 @@
        >
          ecash:qzagy47mvh6qxkvcn3acjnz73rkhkc6y7ccxkrr6zd
        </span>
      </div>
      <svg
-       className="sc-jzJRlG dWXZEC"
+       className="sc-jzJRlG dYsuyj"
        height={210}
        id="borderedQRCode"
        shapeRendering="crispEdges"
        viewBox="0 0 37 37"
        width={210}
    at Object.<anonymous> (/work/web/cashtab/src/components/Wallet/__tests__/Wallet.test.js:75:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Wallet with BCH balances and tokens and state field

Harbormaster completed remote builds in B17137: Diff 30695.Oct 28 2021, 23:09
bytesofman requested changes to this revision.Oct 28 2021, 23:12

need to update snapshots

This revision now requires changes to proceed.Oct 28 2021, 23:12
kieran709 updated this revision to Diff 30696.EditedOct 29 2021, 00:51

updated snapshots

Harbormaster completed remote builds in B17138: Diff 30696.Oct 29 2021, 00:53
bytesofman accepted this revision.Oct 29 2021, 17:51
This revision is now accepted and ready to land.Oct 29 2021, 17:51
Closed by commit rABC992c9fc7d6a7: [Cashtab] Styling Update (authored by kieran709). · Explain WhyOct 29 2021, 18:48
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC992c9fc7d6a7: [Cashtab] Styling Update.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
assets/
styles/
4 lines
components/
6 lines
Common/
3 lines
Tokens/
__tests__/
__snapshots__/
Wallet/
9 lines
10 lines
__tests__/
__snapshots__/

Diff 30696

View Options

web/cashtab/src/assets/styles/theme.js

Loading...
View Options

web/cashtab/src/components/App.js

Loading...
View Options

web/cashtab/src/components/Common/QRCode.js

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

Loading...
View Options

web/cashtab/src/components/Wallet/TokenListItem.js

Loading...
View Options

web/cashtab/src/components/Wallet/Tx.js

Loading...
View Options

web/cashtab/src/components/Wallet/__tests__/__snapshots__/Wallet.test.js.snap

Loading...