Page MenuHomePhabricator

ProcessOrphanTx: Remove aliases
ClosedPublic

Authored by PiRK on Nov 2 2021, 10:47.

Details

Reviewers
majcosta
Group Reviewers
Restricted Project
Commits
rABC9b3b55dcccb4: ProcessOrphanTx: Remove aliases
Summary
Test Plan

ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Nov 2 2021, 10:48

Tail of the build log:

[345/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[346/510] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[347/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[348/510] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[349/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[350/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[351/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[352/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[353/510] Linking CXX static library src/libbitcoinconsensus.a
[354/510] Linking C executable src/secp256k1/ecmult-bench
[355/510] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[356/510] Linking C executable src/secp256k1/sign-bench
[357/510] Linking C executable src/secp256k1/verify-bench
[358/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[359/510] Linking C executable src/secp256k1/internal-bench
[360/510] Linking C executable src/secp256k1/recover-bench
[361/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[362/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[363/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[364/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[365/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[366/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[367/510] Building CXX object src/CMakeFiles/server.dir/avalanche/proofbuilder.cpp.o
[368/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[369/510] Linking CXX static library src/libscript.a
[370/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[371/510] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[372/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[373/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[374/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[375/510] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[376/510] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[377/510] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[378/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[379/510] Linking CXX static library src/libcommon.a
[380/510] Linking CXX shared library src/libbitcoinconsensus.so.0.24.5
[381/510] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[382/510] Linking CXX executable src/bitcoin-cli
[383/510] Linking CXX executable src/bitcoin-tx
[384/510] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[385/510] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[386/510] Linking CXX static library src/wallet/libwallet.a
[387/510] Linking CXX static library src/wallet/libwallet-tool.a
[388/510] Linking CXX executable src/bitcoin-wallet
[389/510] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
FAILED: src/CMakeFiles/server.dir/net_processing.cpp.o 
/usr/bin/ccache /usr/bin/clang++  -DBOOST_AC_USE_STD_ATOMIC -DBOOST_SP_USE_STD_ATOMIC -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I../../src/leveldb/helpers/memenv -I../../src/. -Isrc -I../../src/univalue/include -Isrc/crypto/.. -I../../src/secp256k1/include -I../../src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden   -fstack-protector-all -Wstack-protector -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -pthread -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/net_processing.cpp.o -MF src/CMakeFiles/server.dir/net_processing.cpp.o.d -o src/CMakeFiles/server.dir/net_processing.cpp.o -c ../../src/net_processing.cpp
../../src/net_processing.cpp:283:27: error: unused variable 'MAX_NON_STANDARD_ORPHAN_PER_NODE' [-Werror,-Wunused-const-variable]
static constexpr uint32_t MAX_NON_STANDARD_ORPHAN_PER_NODE = 5;
                          ^
1 error generated.
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
majcosta requested changes to this revision.Nov 2 2021, 18:56
majcosta added a subscriber: majcosta.

oh, these are all D10414 's fault

This revision now requires changes to proceed.Nov 2 2021, 18:56
This revision is now accepted and ready to land.Nov 2 2021, 20:49
This revision was automatically updated to reflect the committed changes.