net: Send post-verack handshake messages at most once
ClosedPublic
Actions

Authored by PiRK on Nov 12 2021, 09:04.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCd0db96b0219e: net: Send post-verack handshake messages at most once

Summary

There is no need to send SENDHEADERS and SENDCMPCT messages as a reply to each VERACK that is received. For alive checks, a PING/PONG can be used.

This is a backport of core#20146

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr20146

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17244
Build 34319: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang-tidy · build-debug · build-clang
Build 34318: arc lint + arc unit

Event Timeline

PiRK created this revision.Nov 12 2021, 09:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 12 2021, 09:04

PiRK requested review of this revision.Nov 12 2021, 09:04

Harbormaster completed remote builds in B17244: Diff 30856.Nov 12 2021, 09:19

Is that a PR ?

PiRK edited the summary of this revision. (Show Details)Nov 17 2021, 09:58

Fabien accepted this revision.Nov 17 2021, 14:54

This revision is now accepted and ready to land.Nov 17 2021, 14:54

Closed by commit rABCd0db96b0219e: net: Send post-verack handshake messages at most once (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyNov 17 2021, 16:38

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCd0db96b0219e: net: Send post-verack handshake messages at most once.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

4 lines

Diff 30856

View Options

net: Send post-verack handshake messages at most onceClosedPublicActions