Page MenuHomePhabricator
Differential D10574

Update wallet_multiwallet.py for descriptor and sqlite wallets
AbandonedPublic
Actions

Authored by PiRK on Nov 26 2021, 16:01.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

This concludes backport of core#19077 [26/26]
https://github.com/bitcoin/bitcoin/pull/19077/commits/c4a29d0a90b821c443c10891d9326c534d15cf97
Depends on D10573

Test Plan

ninja check-functional

Diff Detail

Event Timeline

PiRK created this revision.Nov 26 2021, 16:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 16:01
PiRK requested review of this revision.Nov 26 2021, 16:01
teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 16:03
Harbormaster completed remote builds in B17411: Diff 31101.Nov 26 2021, 16:32
PiRK added a child revision: D10576: rpc, wallet: Expose database format in getwalletinfo.Nov 26 2021, 16:36
PiRK planned changes to this revision.Nov 30 2021, 17:47
PiRK updated this revision to Diff 31199.Dec 1 2021, 10:06

rebase

Harbormaster completed remote builds in B17482: Diff 31199.Dec 1 2021, 10:24
teamcity added a comment.Dec 1 2021, 10:24
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

rpc_signrawtransaction.py                    | ✓ Passed  | 2 s
rpc_txoutproof.py                            | ✓ Passed  | 1 s
rpc_uptime.py                                | ✓ Passed  | 1 s
rpc_users.py                                 | ✓ Passed  | 7 s
rpc_whitelist.py                             | ✓ Passed  | 1 s
tool_wallet.py                               | ✓ Passed  | 6 s
wallet_abandonconflict.py                    | ✓ Passed  | 7 s
wallet_address_types.py                      | ✓ Passed  | 18 s
wallet_avoidreuse.py                         | ✓ Passed  | 13 s
wallet_avoidreuse.py --descriptors           | ✓ Passed  | 24 s
wallet_backup.py                             | ✓ Passed  | 28 s
wallet_backup.py --descriptors               | ✓ Passed  | 20 s
wallet_balance.py                            | ✓ Passed  | 13 s
wallet_basic.py                              | ✓ Passed  | 28 s
wallet_coinbase_category.py                  | ✓ Passed  | 1 s
wallet_create_tx.py                          | ✓ Passed  | 19 s
wallet_createwallet.py                       | ✓ Passed  | 5 s
wallet_createwallet.py --usecli              | ✓ Passed  | 5 s
wallet_descriptor.py                         | ✓ Passed  | 29 s
wallet_disable.py                            | ✓ Passed  | 1 s
wallet_dump.py                               | ✓ Passed  | 9 s
wallet_encryption.py                         | ✓ Passed  | 6 s
wallet_encryption.py --descriptors           | ✓ Passed  | 6 s
wallet_hd.py                                 | ✓ Passed  | 8 s
wallet_hd.py --descriptors                   | ✓ Passed  | 8 s
wallet_import_rescan.py                      | ✓ Passed  | 16 s
wallet_import_with_label.py                  | ✓ Passed  | 1 s
wallet_importdescriptors.py                  | ✓ Passed  | 7 s
wallet_importmulti.py                        | ✓ Passed  | 5 s
wallet_importprunedfunds.py                  | ✓ Passed  | 2 s
wallet_keypool.py                            | ✓ Passed  | 3 s
wallet_keypool_topup.py                      | ✓ Passed  | 3 s
wallet_keypool_topup.py --descriptors        | ✓ Passed  | 9 s
wallet_labels.py                             | ✓ Passed  | 5 s
wallet_labels.py --descriptors               | ✓ Passed  | 4 s
wallet_listreceivedby.py                     | ✓ Passed  | 10 s
wallet_listsinceblock.py                     | ✓ Passed  | 4 s
wallet_listtransactions.py                   | ✓ Passed  | 14 s
wallet_multiwallet.py --usecli --descriptors | ✓ Passed  | 12 s
wallet_reorgsrestore.py                      | ✓ Passed  | 5 s
wallet_resendwallettransactions.py           | ✓ Passed  | 6 s
wallet_send.py                               | ✓ Passed  | 8 s
wallet_startup.py                            | ✓ Passed  | 4 s
wallet_txn_clone.py                          | ✓ Passed  | 5 s
wallet_txn_clone.py --mineblock              | ✓ Passed  | 6 s
wallet_txn_doublespend.py                    | ✓ Passed  | 4 s
wallet_txn_doublespend.py --mineblock        | ✓ Passed  | 6 s
wallet_watchonly.py                          | ✓ Passed  | 1 s
wallet_watchonly.py --usecli                 | ✓ Passed  | 3 s

ALL                                          | ✓ Passed  | 1189 s (accumulated) 
Runtime: 251 s

----------------------------------------------------------------------
Ran 10 tests in 0.092s

OK

ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK updated this revision to Diff 31202.Dec 1 2021, 11:22

rebase (unrelated test failure)

Harbormaster completed remote builds in B17485: Diff 31202.Dec 1 2021, 11:33
PiRK removed a child revision: D10576: rpc, wallet: Expose database format in getwalletinfo.Dec 15 2021, 16:35
PiRK updated this revision to Diff 31432.Dec 15 2021, 16:59

rebase

Harbormaster completed remote builds in B17656: Diff 31432.Dec 15 2021, 17:14
Fabien requested changes to this revision.Dec 20 2021, 08:52
Fabien added a subscriber: Fabien.

Does this depend on sqlite ? If yes this should be squashed (you don't want the test to break), if not this should be moved before sqlite is enabled

This revision now requires changes to proceed.Dec 20 2021, 08:52
PiRK updated this revision to Diff 31476.EditedDec 20 2021, 14:45

rebase

In D10574#240136, @Fabien wrote:

Does this depend on sqlite ? If yes this should be squashed (you don't want the test to break), if not this should be moved before sqlite is enabled

It depends on sqlite.

Harbormaster completed remote builds in B17688: Diff 31476.Dec 20 2021, 15:05
PiRK edited parent revisions, added: D10572: doc: Update wallet files in files.md; removed: D10573: Run dumpwallet for legacy wallets only in wallet_backup.py.Dec 20 2021, 17:14
PiRK abandoned this revision.Dec 20 2021, 17:19

Clearing my queue

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
2 lines
2 lines
62 lines

Diff 31101

View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_runner.py

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...