Page MenuHomePhabricator
Differential D10571

wallet: Enforce sqlite serialized threading mode
AbandonedPublic
Actions

Authored by PiRK on Nov 26 2021, 15:17.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

From the sqlite documentation https://www.sqlite.org/threadsafe.html: "In serialized mode, SQLite can be safely used by multiple threads with no restriction."

This is a backport of core#19077 [21/26]
https://github.com/bitcoin/bitcoin/pull/19077/commits/f023b7cac0eb16d3c1bf40f1f7898b290de4cc73

Depends on D10570

Test Plan

With clang-tidy:
ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Nov 26 2021, 15:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2021, 15:17
PiRK requested review of this revision.Nov 26 2021, 15:17
teamcity edited the summary of this revision. (Show Details)Nov 26 2021, 15:17
PiRK added a child revision: D10572: doc: Update wallet files in files.md.Nov 26 2021, 15:21
Harbormaster completed remote builds in B17408: Diff 31095.Nov 26 2021, 16:13
PiRK planned changes to this revision.Nov 30 2021, 17:47
PiRK updated this revision to Diff 31192.Dec 1 2021, 08:57
PiRK edited the summary of this revision. (Show Details)
PiRK edited the test plan for this revision. (Show Details)

Move this commit from position [23/26] to [21/26], before sqlite wallet are actually read or created

Harbormaster completed remote builds in B17475: Diff 31192.Dec 1 2021, 09:16
PiRK mentioned this in D10568: Use SQLite for descriptor wallets.Dec 1 2021, 09:57
PiRK added a child revision: D10568: Use SQLite for descriptor wallets.Dec 1 2021, 10:13
PiRK removed a child revision: D10572: doc: Update wallet files in files.md.
Fabien accepted this revision.Dec 3 2021, 20:09
This revision is now accepted and ready to land.Dec 3 2021, 20:09
PiRK added a child revision: D10576: rpc, wallet: Expose database format in getwalletinfo.Dec 15 2021, 16:34
PiRK removed a child revision: D10568: Use SQLite for descriptor wallets.Dec 15 2021, 16:51
PiRK abandoned this revision.Dec 20 2021, 17:18

Clearing my queue

Revision Contents
Changeset List

PathSize
src/
wallet/
8 lines

Diff 31192

View Options

src/wallet/sqlite.cpp

Loading...