Differential D10624

[avalanche] Move back proof verification to the peer creation
AbandonedPublic
Actions

Authored by Fabien on Dec 3 2021, 14:09.

Details

Reviewers

None

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Summary

This diff is a partial revert of D10453.

As part of the conflicting proof management, we need to be able to accept or reject a proof depending on the avalanche vote, i.e. bring back a proof from orphans and turn it into a peer, or remove a peer and make it an orphan.

In this case the cooldown time should not happen, but proof validation is still needed. The current proof pool design causes D10453 to be in the way of this feature, as it makes it impossible to call createPeer without duplicating the proof verification, so this diff reverts that.
The orphan proof removal is also added back; strictly speaking it's not needed, but it makes the code easier to reason about. Next step is to pass the cooldown value to createPeer.

There is no change in behavior.

Ref T1854.

Depends on D10525.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_move_validation_createpeer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17525
Build 34876: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 34875: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 3 2021, 14:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2021, 14:09

Fabien requested review of this revision.Dec 3 2021, 14:09

Harbormaster completed remote builds in B17523: Diff 31247.Dec 3 2021, 14:12

Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[340/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[341/511] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[342/511] Linking C static library src/secp256k1/libsecp256k1.a
[343/511] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[344/511] Linking C executable src/secp256k1/ecmult-bench
[345/511] Linking CXX static library src/libbitcoinconsensus.a
[346/511] Linking C executable src/secp256k1/internal-bench
[347/511] Linking C executable src/secp256k1/sign-bench
[348/511] Linking C executable src/secp256k1/verify-bench
[349/511] Linking C executable src/secp256k1/recover-bench
[350/511] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[351/511] Installing component secp256k1
-- Install configuration: "Debug"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[352/511] Linking CXX static library src/libscript.a
[353/511] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[354/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[355/511] Linking CXX static library src/libcommon.a
[356/511] Linking CXX shared library src/libbitcoinconsensus.so.0.24.7
[357/511] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[358/511] Linking CXX executable src/bitcoin-cli
[359/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[360/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[361/511] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[362/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[363/511] Linking CXX executable src/bitcoin-tx
[364/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[365/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[366/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[367/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[368/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[369/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[370/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[371/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[372/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[373/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/511] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[375/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[376/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[377/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[378/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[379/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[380/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[381/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[382/511] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[383/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[384/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[385/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[386/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[387/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[388/511] Linking CXX static library src/wallet/libwallet.a
[389/511] Linking CXX static library src/wallet/libwallet-tool.a
[390/511] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[333/511] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[334/511] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[335/511] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[336/511] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[337/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[338/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[339/511] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[340/511] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[341/511] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[342/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[343/511] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[344/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[345/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[346/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[347/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[348/511] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[349/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[350/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[351/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[352/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[353/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[354/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[355/511] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[356/511] Linking CXX static library src/libutil.a
[357/511] Linking CXX static library src/librpcclient.a
[358/511] Linking CXX static library src/libbitcoinconsensus.a
[359/511] Linking CXX static library src/libscript.a
[360/511] Linking CXX static library src/libcommon.a
[361/511] Linking CXX shared library src/libbitcoinconsensus.so.0.24.7
[362/511] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[363/511] Linking CXX executable src/bitcoin-cli
[364/511] Linking CXX executable src/bitcoin-tx
[365/511] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[366/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[367/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[368/511] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[369/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[370/511] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
[371/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[372/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[373/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/511] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[375/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[376/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[377/511] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[378/511] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[379/511] Linking CXX static library src/zmq/libzmq.a
[380/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[381/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[382/511] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[383/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[384/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[385/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[386/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[387/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[388/511] Linking CXX static library src/wallet/libwallet.a
[389/511] Linking CXX static library src/wallet/libwallet-tool.a
[390/511] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[310/457] Building CXX object src/CMakeFiles/server.dir/node/transaction.cpp.o
[311/457] Building CXX object src/CMakeFiles/server.dir/pow/pow.cpp.o
[312/457] Building CXX object src/CMakeFiles/server.dir/pow/aserti32d.cpp.o
[313/457] Building CXX object src/CMakeFiles/server.dir/net.cpp.o
[314/457] Building CXX object src/CMakeFiles/server.dir/rpc/abc.cpp.o
[315/457] Building CXX object src/CMakeFiles/server.dir/shutdown.cpp.o
[316/457] Building CXX object src/CMakeFiles/server.dir/node/ui_interface.cpp.o
[317/457] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[318/457] Building CXX object src/CMakeFiles/server.dir/rest.cpp.o
[319/457] Building CXX object src/CMakeFiles/server.dir/timedata.cpp.o
[320/457] Building CXX object src/CMakeFiles/server.dir/script/sigcache.cpp.o
[321/457] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[322/457] Building CXX object src/CMakeFiles/server.dir/rpc/server.cpp.o
[323/457] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[324/457] Building CXX object src/CMakeFiles/server.dir/txdb.cpp.o
[325/457] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[326/457] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[327/457] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[328/457] Building CXX object src/CMakeFiles/server.dir/versionbits.cpp.o
[329/457] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[330/457] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[331/457] Building CXX object src/CMakeFiles/server.dir/dummywallet.cpp.o
[332/457] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[333/457] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[334/457] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[335/457] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[336/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[337/457] Linking C static library src/secp256k1/libsecp256k1.a
[338/457] Building CXX object src/CMakeFiles/server.dir/init.cpp.o
[339/457] Linking CXX static library src/libcommon.a
[340/457] Linking C executable src/secp256k1/ecmult-bench
[341/457] Linking CXX static library src/libscript.a
[342/457] Linking C executable src/secp256k1/internal-bench
[343/457] Linking CXX static library src/libbitcoinconsensus.a
[344/457] Linking C executable src/secp256k1/sign-bench
[345/457] Linking CXX shared library src/libbitcoinconsensus.so.0.24.7
[346/457] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[347/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[348/457] Linking CXX executable src/bitcoin-cli
[349/457] Linking C executable src/secp256k1/verify-bench
[350/457] Linking C executable src/secp256k1/recover-bench
[351/457] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[352/457] Linking CXX executable src/bitcoin-tx
[353/457] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[354/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[355/457] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[356/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[357/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[358/457] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[359/457] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[360/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[361/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[362/457] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[363/457] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[364/457] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[365/457] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[366/457] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[367/457] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[340/511] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[341/511] Linking C static library src/secp256k1/libsecp256k1.a
[342/511] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[343/511] Linking CXX static library src/libbitcoinconsensus.a
[344/511] Linking C executable src/secp256k1/ecmult-bench
[345/511] Linking C executable src/secp256k1/internal-bench
[346/511] Linking C executable src/secp256k1/sign-bench
[347/511] Linking C executable src/secp256k1/verify-bench
[348/511] Linking C executable src/secp256k1/recover-bench
[349/511] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[350/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[351/511] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[352/511] Linking CXX static library src/libscript.a
[353/511] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[354/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[355/511] Linking CXX static library src/libcommon.a
[356/511] Linking CXX shared library src/libbitcoinconsensus.so.0.24.7
[357/511] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[358/511] Linking CXX executable src/bitcoin-cli
[359/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[360/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[361/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[362/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[363/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[364/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[365/511] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[366/511] Linking CXX executable src/bitcoin-tx
[367/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[368/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[369/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[370/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[371/511] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[372/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[373/511] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[374/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[375/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[376/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[377/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[378/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[379/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[380/511] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[381/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[382/511] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[383/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[384/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[385/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[386/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[387/511] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[388/511] Linking CXX static library src/wallet/libwallet.a
[389/511] Linking CXX static library src/wallet/libwallet-tool.a
[390/511] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Fabien added a child revision: D10625: [avalanche] Pass down the cooldown value to createPeer.Dec 3 2021, 14:13

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[332/509] Building CXX object src/CMakeFiles/util.dir/util/error.cpp.o
[333/509] Building CXX object src/CMakeFiles/util.dir/util/settings.cpp.o
[334/509] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[335/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[336/509] Building CXX object src/CMakeFiles/util.dir/util/message.cpp.o
[337/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[338/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[339/509] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[340/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[341/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[342/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[343/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[344/509] Building CXX object src/CMakeFiles/util.dir/util/time.cpp.o
[345/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[346/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[347/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[348/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[349/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[350/509] Building CXX object src/CMakeFiles/util.dir/util/system.cpp.o
[351/509] Linking CXX static library src/libutil.a
[352/509] Linking CXX static library src/librpcclient.a
[353/509] Linking CXX static library src/libbitcoinconsensus.a
[354/509] Linking CXX static library src/libscript.a
[355/509] Linking CXX static library src/libcommon.a
[356/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[357/509] Linking CXX shared library src/libbitcoinconsensus.so.0.24.7
[358/509] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[359/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[360/509] Linking CXX executable src/bitcoin-cli
[361/509] Linking CXX executable src/bitcoin-tx
[362/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[363/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[364/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqabstractnotifier.cpp.o
[365/509] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[366/509] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[367/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[368/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[369/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqnotificationinterface.cpp.o
[370/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[371/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[372/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqutil.cpp.o
[373/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[374/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/__/interfaces/wallet.cpp.o
[375/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[376/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[377/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqrpc.cpp.o
[378/509] Building CXX object src/zmq/CMakeFiles/zmq.dir/zmqpublishnotifier.cpp.o
[379/509] Linking CXX static library src/zmq/libzmq.a
[380/509] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[381/509] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[382/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[383/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[384/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcdump.cpp.o
[385/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[386/509] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[387/509] Linking CXX static library src/wallet/libwallet.a
[388/509] Linking CXX static library src/wallet/libwallet-tool.a
[389/509] Linking CXX executable src/bitcoin-wallet
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Fabien planned changes to this revision.Dec 3 2021, 14:14

Rebase issue, the static function was moved in the latter diff (D10625) instead of this one.

Harbormaster completed remote builds in B17525: Diff 31249.Dec 3 2021, 14:38

Fabien planned changes to this revision.Dec 3 2021, 15:17

Fabien requested review of this revision.Dec 3 2021, 16:51

Rebase

Fabien added a child revision: D10615: [avalanche] Add an API to accept or reject a proof.Dec 8 2021, 16:02

Harbormaster completed remote builds in B17578: Diff 31323.Dec 8 2021, 16:15

Fabien planned changes to this revision.Dec 8 2021, 19:27

Fabien removed a child revision: D10615: [avalanche] Add an API to accept or reject a proof.Dec 10 2021, 11:09

Fabien abandoned this revision.Feb 9 2022, 13:29