Page MenuHomePhabricator
Differential D10712

[avalanche] Simplify the updatedBlockTip handler
ClosedPublic
Actions

Authored by Fabien on Dec 21 2021, 09:24.

Details

Reviewers
tyler-smith
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABC42afa7ecdae3: [avalanche] Simplify the updatedBlockTip handler
Summary

We can use the rejectProof facility for newly invalidated proofs. This avoids a duplicate and makes the code more readable. There is no change in behavior.

Ref T1854.

Depends on D10711.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Dec 21 2021, 09:24
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 21 2021, 09:24
Fabien requested review of this revision.Dec 21 2021, 09:24
Harbormaster completed remote builds in B17706: Diff 31503.Dec 21 2021, 09:53
Fabien planned changes to this revision.Dec 24 2021, 08:13
Fabien updated this revision to Diff 31687.Jan 7 2022, 10:55

Rebase

Harbormaster completed remote builds in B17827: Diff 31687.Jan 7 2022, 11:28
Fabien updated this revision to Diff 31748.Jan 11 2022, 08:57

Rebase

Harbormaster completed remote builds in B17877: Diff 31748.Jan 11 2022, 09:23
tyler-smith accepted this revision as: tyler-smith.Jan 26 2022, 09:38
tyler-smith added a subscriber: tyler-smith.

The iterating over proofs instead of peers looks better, and the removal logic appears correctly deduplicated without change in behavior.

This revision is now accepted and ready to land.Jan 26 2022, 09:38
Closed by commit rABC42afa7ecdae3: [avalanche] Simplify the updatedBlockTip handler (authored by Fabien). · Explain WhyFeb 9 2022, 08:55
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC42afa7ecdae3: [avalanche] Simplify the updatedBlockTip handler.

Revision Contents
Changeset List

PathSize
src/
avalanche/
29 lines

Diff 32295

View Options

src/avalanche/peermanager.cpp

Loading...