Page MenuHomePhabricator
Differential D10640

[Cashtab] removed extra spaces on currency ticker
ClosedPublic
Actions

Authored by kieran709 on Dec 7 2021, 11:43.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC784d366c91bd: [Cashtab] removed extra spaces on currency ticker
Summary

Removed extra space after currency ticker on 'not enough XEC to mint token' error text. Related to task T2056.

Test Plan

cd web/cashtab && npm start
navigate to settings tab
select empty wallet
navigate to eTokens page
ensure extra space is removed from error text

Diff Detail

Repository
rABC Bitcoin ABC
Branch
remove-empty-space
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17577
Build 34980: Build Diffcashtab-tests
Build 34979: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 7 2021, 11:43
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 7 2021, 11:43
kieran709 requested review of this revision.Dec 7 2021, 11:43
Harbormaster completed remote builds in B17558: Diff 31298.Dec 7 2021, 11:46
teamcity added a comment.Dec 7 2021, 11:46
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.

Failed tests logs:

====== CashTab Unit Tests:  Wallet without BCH balance ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet without BCH balance 1`

- Snapshot  - 1
+ Received  + 1

@@ -110,11 +110,11 @@
       
      5.5
       
      XEC
       (
-     $ 
+     $
      NaN
       
      USD
      ) to create a token
    </p>,
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:54:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances 1`

- Snapshot  - 1
+ Received  + 1

@@ -110,11 +110,11 @@
       
      5.5
       
      XEC
       (
-     $ 
+     $
      NaN
       
      USD
      ) to create a token
    </p>,
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:68:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Wallet with BCH balances and tokens ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Wallet with BCH balances and tokens 1`

- Snapshot  - 1
+ Received  + 1

@@ -110,11 +110,11 @@
       
      5.5
       
      XEC
       (
-     $ 
+     $
      NaN
       
      USD
      ) to create a token
    </p>,
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:82:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)
====== CashTab Unit Tests:  Without wallet defined ======
Error: expect(received).toMatchSnapshot()

Snapshot name: `Without wallet defined 1`

- Snapshot  - 1
+ Received  + 1

@@ -110,11 +110,11 @@
       
      5.5
       
      XEC
       (
-     $ 
+     $
      NaN
       
      USD
      ) to create a token
    </p>,
    at Object.<anonymous> (/work/web/cashtab/src/components/Tokens/__tests__/Tokens.test.js:114:18)
    at Object.asyncJestTest (/work/web/cashtab/node_modules/jest-jasmine2/build/jasmineAsyncInstall.js:106:37)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:45:12
    at new Promise (<anonymous>)
    at mapper (/work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:28:19)
    at /work/web/cashtab/node_modules/jest-jasmine2/build/queueRunner.js:75:41
    at processTicksAndRejections (node:internal/process/task_queues:94:5)

Each failure log is accessible here:
CashTab Unit Tests: Wallet without BCH balance
CashTab Unit Tests: Wallet with BCH balances
CashTab Unit Tests: Wallet with BCH balances and tokens
CashTab Unit Tests: Without wallet defined

bytesofman requested changes to this revision.Dec 7 2021, 22:40

Please correct unit test failures.

This revision now requires changes to proceed.Dec 7 2021, 22:40
kieran709 updated this revision to Diff 31322.Dec 8 2021, 15:45

Updated snapshots to correct unit test failures.

Harbormaster completed remote builds in B17577: Diff 31322.Dec 8 2021, 16:01
emack added a subscriber: emack.Dec 12 2021, 22:59

green for 1st level review

bytesofman accepted this revision.Dec 13 2021, 19:36
This revision is now accepted and ready to land.Dec 13 2021, 19:36
Closed by commit rABC784d366c91bd: [Cashtab] removed extra spaces on currency ticker (authored by kieran709). · Explain WhyDec 13 2021, 20:29
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABC784d366c91bd: [Cashtab] removed extra spaces on currency ticker.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Tokens/
4 lines
__tests__/
__snapshots__/

Diff 31322

View Options

web/cashtab/src/components/Tokens/Tokens.js

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

Loading...