Paths

Table of Contentst

Differential D10672

Disable some tests for tool_wallet when descriptors
ClosedPublic
Actions

Authored by PiRK on Dec 14 2021, 16:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC5b31979a5c3d: Disable some tests for tool_wallet when descriptors

Summary

Some tests are legacy wallet only (and make legacy wallets) so they shouldn't be run when doing descriptor wallet tests.

This is a backport of core#18788 [10/15]
https://github.com/bitcoin/bitcoin/pull/18788/commits/388053e1722632c2e485c56a444bc75cf0152188

Test Plan

test/functional/test_runner.py tool_wallet

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17631
Build 35088: Build Diff	build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 35087: arc lint + arc unit

Event Timeline

PiRK created this revision.Dec 14 2021, 16:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 14 2021, 16:49

PiRK requested review of this revision.Dec 14 2021, 16:49

teamcity edited the summary of this revision. (Show Details)Dec 14 2021, 16:49

Harbormaster completed remote builds in B17631: Diff 31395.Dec 14 2021, 17:04

Fabien accepted this revision.Dec 15 2021, 13:50

This revision is now accepted and ready to land.Dec 15 2021, 13:50

Closed by commit rABC5b31979a5c3d: Disable some tests for tool_wallet when descriptors (authored by Andrew Chow <achow101-github@achow101.com>, committed by PiRK). · Explain WhyDec 16 2021, 15:58

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC5b31979a5c3d: Disable some tests for tool_wallet when descriptors.

PiRK mentioned this in D10568: Use SQLite for descriptor wallets.Dec 20 2021, 14:39

Revision Contents
Changeset List

Path

Size

test/

functional/

test_runner.py

1 line

tool_wallet.py

10 lines

Diff 31395

View Options

test/functional/test_runner.py