Page MenuHomePhabricator
Differential D10703

[Cashtab] Clear form data on eToken send
ClosedPublic
Actions

Authored by kieran709 on Dec 20 2021, 17:41.

Details

Reviewers
emack
bytesofman
Group Reviewers
Restricted Project
Commits
rABCaec24e9d631b: [Cashtab] Clear form data on eToken send
Summary

Added function which clears the address and amount fields when sending eTokens. Related to task T2106.

Test Plan

cd web/cashtab && npm start
navigate to send-token
send token and ensure form data is cleared

Diff Detail

Repository
rABC Bitcoin ABC
Branch
clear-sendToken-input-fields
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 17697
Build 35220: Build Diffcashtab-tests
Build 35219: arc lint + arc unit

Event Timeline

kieran709 created this revision.Dec 20 2021, 17:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 20 2021, 17:41
kieran709 requested review of this revision.Dec 20 2021, 17:41
Harbormaster completed remote builds in B17693: Diff 31483.Dec 20 2021, 17:44
bytesofman requested changes to this revision.Dec 20 2021, 22:01

See inline comment.

Please also create a task to remove the dirty: param from SendToken.js

web/cashtab/src/components/Send/SendToken.js
81 ↗(On Diff #31483)

The opReturnMsg key is not relevant for SendToken.js

This revision now requires changes to proceed.Dec 20 2021, 22:01
kieran709 updated this revision to Diff 31487.Dec 20 2021, 22:23

Responding to review feedback

Harbormaster completed remote builds in B17697: Diff 31487.Dec 20 2021, 22:26
bytesofman accepted this revision.Dec 21 2021, 18:19
This revision is now accepted and ready to land.Dec 21 2021, 18:19
Closed by commit rABCaec24e9d631b: [Cashtab] Clear form data on eToken send (authored by kieran709). · Explain WhyDec 21 2021, 18:25
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABCaec24e9d631b: [Cashtab] Clear form data on eToken send.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Send/
10 lines

Diff 31487

View Options

web/cashtab/src/components/Send/SendToken.js

Loading...