[Cashtab] Add correct dev dependency for ESlint types in jest
ClosedPublic
Actions

Authored by bytesofman on Jan 6 2022, 10:49.

Details

Reviewers

Fabien
emack

Group Reviewers

Restricted Project

Commits

rABC7d75d11530e2: [Cashtab] Add correct dev dependency for ESlint types in jest

Summary

Prelim for T2088

Cashtab devs will see linting errors in their IDE for all test files as the correct dev dependency for the jest types used is not installed. This diff corrects the issue.

Test Plan

Open any .test.js file in VS code
Confirm jest terms are not highlighted in red as lint errors (e.g. it, describe, expect)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

add-linting-scripts

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17802
Build 35430: Build Diff	cashtab-tests
Build 35429: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jan 6 2022, 10:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 6 2022, 10:49

bytesofman requested review of this revision.Jan 6 2022, 10:49

Harbormaster completed remote builds in B17802: Diff 31659.Jan 6 2022, 10:52

bytesofman mentioned this in D10810: allow eslint to recongnize jest syntax.Jan 11 2022, 22:34

There is no point linting all the files every time, you only need to lint the ones you edited. I don't think this approach makes sense.

This revision now requires changes to proceed.Jan 13 2022, 08:25

bytesofman retitled this revision from [Cashtab] Support react and jsx specific linting to [Cashtab] Add correct dev dependency for ESlint types in jest.Jan 13 2022, 20:29

bytesofman edited the summary of this revision. (Show Details)

bytesofman edited the test plan for this revision. (Show Details)

Removing the npm script

Harbormaster completed remote builds in B17906: Diff 31802.Jan 13 2022, 20:34

Fabien accepted this revision.Jan 13 2022, 21:14

This revision is now accepted and ready to land.Jan 13 2022, 21:14

Closed by commit rABC7d75d11530e2: [Cashtab] Add correct dev dependency for ESlint types in jest (authored by Joey King <joseph.roy.king@gmail.com>). · Explain WhyJan 13 2022, 22:39

This revision was automatically updated to reflect the committed changes.

Joey King <joseph.roy.king@gmail.com> added a commit: rABC7d75d11530e2: [Cashtab] Add correct dev dependency for ESlint types in jest.