Differential D10881

net: Move SocketSendData lock annotation to header
ClosedPublic
Actions

Authored by Fabien on Jan 25 2022, 09:20.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Maniphest Tasks

Restricted Maniphest Task

Commits

rABC13db67570818: net: Move SocketSendData lock annotation to header

Summary

Also, add lock annotation to SendMessages

Can be reviewed with "--word-diff-regex=."

Completes backport of core#20864:
https://github.com/bitcoin/bitcoin/pull/20864/commits/fa210689e27b0d78b2fe894e51e364179db7a3ce

Depends on D10880.

Ref T1696.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR20864_p2

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 17991
Build 35804: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 35803: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 25 2022, 09:20

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 25 2022, 09:20

Fabien requested review of this revision.Jan 25 2022, 09:20

teamcity edited the summary of this revision. (Show Details)Jan 25 2022, 09:20

Fabien added a child revision: D10882: net, net_processing: move NetEventsInterface method docs to net.h.Jan 25 2022, 09:34

Harbormaster completed remote builds in B17991: Diff 31933.Jan 25 2022, 09:43

PiRK accepted this revision.Jan 25 2022, 10:40

This revision is now accepted and ready to land.Jan 25 2022, 10:40

Closed by commit rABC13db67570818: net: Move SocketSendData lock annotation to header (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyJan 25 2022, 12:52

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC13db67570818: net: Move SocketSendData lock annotation to header.

Revision Contents
Changeset List

Path

Size

src/

net.h

6 lines

net.cpp

50 lines

Diff 31933

View Options

src/net.h