Page MenuHomePhabricator
Differential D10875

[net] Add RunInactivityChecks()
ClosedPublic
Actions

Authored by Fabien on Jan 24 2022, 20:57.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Maniphest Tasks
Restricted Maniphest Task
Commits
rABCe5046830a7fe: [net] Add RunInactivityChecks()
Summary
Moves the logic to prevent running inactivity checks until the peer has been connected for -peertimeout time into its own function. This will be reused by net_processing later.

Partial backport of core#20721:
https://github.com/bitcoin/bitcoin/pull/20721/commits/1a07600b4b0d08cffc7cd5c58af33fcd1ede558e

Depends on D10873.

Ref T1696.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Jan 24 2022, 20:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 24 2022, 20:58
Fabien requested review of this revision.Jan 24 2022, 20:58
teamcity edited the summary of this revision. (Show Details)Jan 24 2022, 20:58
Harbormaster completed remote builds in B17984: Diff 31924.Jan 24 2022, 21:11
Fabien added a child revision: D10876: [net processing] Move send ping message logic into function.Jan 24 2022, 21:13
Fabien planned changes to this revision.Jan 24 2022, 21:45

Missing dependency, needs rebase

Fabien updated this revision to Diff 31959.Jan 25 2022, 15:20

Rebase

Fabien edited the summary of this revision. (Show Details)Jan 25 2022, 15:20
Fabien removed a parent revision: D10874: [refactor] [net] Clean up InactivityCheck().
Harbormaster completed remote builds in B18006: Diff 31959.Jan 25 2022, 15:44
PiRK accepted this revision.Jan 25 2022, 15:48
This revision is now accepted and ready to land.Jan 25 2022, 15:48
Closed by commit rABCe5046830a7fe: [net] Add RunInactivityChecks() (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyJan 25 2022, 16:39
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe5046830a7fe: [net] Add RunInactivityChecks().

Revision Contents
Changeset List

PathSize
src/
6 lines
13 lines

Diff 31959

View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...