Paths

Table of Contentst

Differential D11085

Use mockable time for peer connection time
ClosedPublic
Actions

Authored by PiRK on Feb 21 2022, 13:53.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe3884eec0daa: Use mockable time for peer connection time

Summary

This allows to revert the temporary fix in test test/functional/p2p_timeouts.py (see 10965)

This is a backport of core#23758 [2/3]
https://github.com/bitcoin/bitcoin/pull/23758/commits/fa663a4c0d20487ed3f7a93e1c2ca9932b05f5a8

Depends on D11084

Note: due to out of sequence backports, we do not yet have void SetMockTime(std::chrono::seconds mock_time_in), so I used void SetMockTime(int64_t nMockTimeIn) instead.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18323
Build 36451: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 36450: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 21 2022, 13:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2022, 13:53

PiRK requested review of this revision.Feb 21 2022, 13:53

teamcity edited the summary of this revision. (Show Details)Feb 21 2022, 13:53

PiRK added a child revision: D11086: scripted-diff: Rename touched CNode member variables.Feb 21 2022, 13:56

Harbormaster completed remote builds in B18323: Diff 32466.Feb 21 2022, 14:15

Fabien accepted this revision.Feb 21 2022, 14:58

This revision is now accepted and ready to land.Feb 21 2022, 14:58

Closed by commit rABCe3884eec0daa: Use mockable time for peer connection time (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyFeb 21 2022, 16:37

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe3884eec0daa: Use mockable time for peer connection time.

Revision Contents
Changeset List

Path

Size

src/

5 lines

test/

denialofservice_tests.cpp

9 lines

test/

functional/

p2p_timeouts.py

2 lines

Diff 32466

src/net.cpp

Loading...

src/test/denialofservice_tests.cpp

Loading...

test/functional/p2p_timeouts.py

Loading...