[avalanche] Add a getavalancheinfo RPC for general status info
ClosedPublic
Actions

Authored by Fabien on Mar 4 2022, 16:47.

Details

Reviewers

Mengerian
tyler-smith

Group Reviewers

Restricted Project

Commits

rABCc5d495ce0325: [avalanche] Add a getavalancheinfo RPC for general status info

Summary

This returns some general informations about how many proofs we know, the total staked amount and how many avalanche nodes we are connected to. This can be used to monitor the avalanche network.

The avalanche query timeout is made configurable to let the test run in a reasonable amount of time (the default timeout is 10s).

Depends on D11131 and D11132.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_getavalancheinfo

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18411
Build 36619: Build Diff	build-without-wallet · lint-circular-dependencies · build-debug · build-diff · build-clang-tidy · build-clang
Build 36618: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 4 2022, 16:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 4 2022, 16:47

Fabien requested review of this revision.Mar 4 2022, 16:47

Harbormaster completed remote builds in B18405: Diff 32594.Mar 4 2022, 17:00

Mengerian requested changes to this revision.Mar 4 2022, 19:49

Mengerian added a subscriber: Mengerian.

Mengerian added inline comments.

src/rpc/avalanche.cpp
575 ↗	(On Diff #32594)	How about calling it "total_stake_amount", to make it totally unambiguous from the fields that return a count.
576 ↗	(On Diff #32594)	Should this specify the unit? Ie, XEC, or satoshi?
577 ↗	(On Diff #32594)	Similarly, I'd call this "connected_stake_amount"