Page MenuHomePhabricator
Differential D11178

[Cashtab] Display fiat price in local currency
ClosedPublic
Actions

Authored by kieran709 on Mar 15 2022, 21:44.

Details

Reviewers
bytesofman
emack
Group Reviewers
Restricted Project
Commits
rABCb16ee3387a73: [Cashtab] Display fiat price in local currency
Summary

Related to task T2300. XEC price in local currency displayed in balance header.

Test Plan

cd web/cashtab
npm start
observe the XEC price in the balance header

Diff Detail

Repository
rABC Bitcoin ABC
Branch
display-xec-price
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18523
Build 36841: Build Diffcashtab-tests
Build 36840: arc lint + arc unit

Event Timeline

kieran709 created this revision.Mar 15 2022, 21:44
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 15 2022, 21:44
kieran709 requested review of this revision.Mar 15 2022, 21:44
Harbormaster completed remote builds in B18497: Diff 32724.Mar 15 2022, 21:47
bytesofman requested changes to this revision.Mar 15 2022, 22:17
bytesofman added inline comments.
web/cashtab/src/components/Home/Home.js
172 ↗(On Diff #32724)

Put this in the existing BalanceHeaderFiat component

This revision now requires changes to proceed.Mar 15 2022, 22:17
kieran709 updated this revision to Diff 32758.Mar 16 2022, 15:00

Responding to review feedback

kieran709 updated this revision to Diff 32759.Mar 16 2022, 15:02

updated snapshots

Harbormaster completed remote builds in B18515: Diff 32758.Mar 16 2022, 15:13
Harbormaster completed remote builds in B18516: Diff 32759.
bytesofman requested changes to this revision.Mar 16 2022, 17:54
bytesofman added inline comments.
web/cashtab/src/components/Common/BalanceHeaderFiat.js
25 ↗(On Diff #32759)

Not necessary to use this ? : logic; instead just use fiatPrice && ; that way it only renders if fiatPrice is not null or false

27 ↗(On Diff #32759)

1 {currency.ticker} = ...

Should be clear this is the unit price of 1 XEC

This revision now requires changes to proceed.Mar 16 2022, 17:54
kieran709 updated this revision to Diff 32769.Mar 16 2022, 18:08

Responding to review feedback

Harbormaster completed remote builds in B18523: Diff 32769.Mar 16 2022, 18:11
bytesofman accepted this revision.Mar 16 2022, 18:41
This revision is now accepted and ready to land.Mar 16 2022, 18:41
Closed by commit rABCb16ee3387a73: [Cashtab] Display fiat price in local currency (authored by kieran709). · Explain WhyMar 16 2022, 18:48
This revision was automatically updated to reflect the committed changes.
kieran709 added a commit: rABCb16ee3387a73: [Cashtab] Display fiat price in local currency.

Revision Contents
Changeset List

PathSize
web/
cashtab/
src/
components/
Common/
16 lines
Home/
__tests__/
__snapshots__/
Send/
__tests__/
__snapshots__/
Tokens/
__tests__/
__snapshots__/

Diff 32769

View Options

web/cashtab/src/components/Common/BalanceHeaderFiat.js

Loading...
View Options

web/cashtab/src/components/Home/__tests__/__snapshots__/Home.test.js.snap

Loading...
View Options

web/cashtab/src/components/Send/__tests__/__snapshots__/Send.test.js.snap

Loading...
View Options

web/cashtab/src/components/Tokens/__tests__/__snapshots__/Tokens.test.js.snap

Loading...