Page MenuHomePhabricator
Differential D1216

Fixed a bug where 0 evaluates to empty list and added a bunch of tests (not all pass)
AbandonedPublic
Actions

Authored by jasonbcox on Mar 18 2018, 18:27.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Summary

WIP work ontop of D1215

Test Plan

make check (currently fails for some tests)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1215
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/test/script_tests.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2167
Build 2478: Bitcoin ABC Buildbot (legacy)
Build 2477: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 18 2018, 18:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2018, 18:27
teamcity added a subscriber: teamcity.Mar 18 2018, 18:29

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel added inline comments.Mar 18 2018, 18:31
src/script/script.cpp
294 ↗(On Diff #3289)

Then we need to fix one edge case, where if the MSB is already set, we need to add another byte to hold it.

teamcity added a comment.Mar 18 2018, 18:47

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2165: Diff 3289!Mar 18 2018, 18:48
jasonbcox updated this revision to Diff 3292.Mar 18 2018, 19:18

Fixed some of the tests and forced the function to return 0x00 when it would return 0x80

teamcity added a comment.Mar 18 2018, 19:18

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

jasonbcox marked an inline comment as done.Mar 18 2018, 19:19
jasonbcox updated this revision to Diff 3293.Mar 18 2018, 19:30

schancel fixed the implementation and I fixed my shoddy tests :D

teamcity added a comment.Mar 18 2018, 19:32

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Mar 18 2018, 19:35

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2167: Diff 3292!Mar 18 2018, 19:35
jasonbcox mentioned this in D1215: Add function to trim leading array zeros maintaining MSB..Mar 18 2018, 19:42
jasonbcox abandoned this revision.Mar 18 2018, 19:44

Merged as part of D1215

teamcity added a comment.Mar 18 2018, 19:50

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2168: Diff 3293.Mar 18 2018, 19:51

Revision Contents
Changeset List

PathSize
src/
script/
22 lines
test/
40 lines

Diff 3292

View Options

src/script/script.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...