Page MenuHomePhabricator

Fixed a bug where 0 evaluates to empty list and added a bunch of tests (not all pass)
AbandonedPublic

Authored by jasonbcox on Mar 18 2018, 18:27.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Summary

WIP work ontop of D1215

Test Plan

make check (currently fails for some tests)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D1215
Lint
Lint Passed
SeverityLocationCodeMessage
Auto-Fixsrc/test/script_tests.cpp:1CFMTCode style violation
Unit
No Test Coverage
Build Status
Buildable 2167
Build 2478: Bitcoin ABC Buildbot (legacy)
Build 2477: arc lint + arc unit

Event Timeline

src/script/script.cpp
294 ↗(On Diff #3289)

Then we need to fix one edge case, where if the MSB is already set, we need to add another byte to hold it.

Fixed some of the tests and forced the function to return 0x00 when it would return 0x80

schancel fixed the implementation and I fixed my shoddy tests :D