Page MenuHomePhabricator

[Cashtab] Airdrop Option - ignore eToken creator address
ClosedPublic

Authored by emack on Mar 25 2022, 04:14.

Details

Summary

As per T2141:
Option to exclude the eToken creator address (eToken minting address) from the list of airdrop recipients, which is useful for eToken projects where the creator still holds a significant portion of the circulating supply.

Dependencies: This diff needs to follow AFTER D11256 as it's leveraging the convertEcashtoEtokenAddr from D11256, hence no unit tests for convertEcashtoEtokenAddr are included here.

Test Plan
  • execute a default airdrop calculation to ensure no regression
  • execute an airdrop calculation with the 'Ignore eToken minter address' option and ensure the minter is excluded from results and the pro rata airdrops are adjusted amongst the filtered recipients
  • ensure the resulting airdrop output is successfully routed to the Send screen and executed successfully onchain
  • ensure no regression routing from the eToken details screen to the airdrops screen
  • integration testing with once D11256, D11245 and D11257 lands

Diff Detail

Repository
rABC Bitcoin ABC
Branch
airdropIgnoreMintAddress
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18629
Build 37049: Build Diffcashtab-tests
Build 37048: arc lint + arc unit

Event Timeline

emack requested review of this revision.Mar 25 2022, 04:14
bytesofman added inline comments.
web/cashtab/src/components/Airdrop/Airdrop.js
408 ↗(On Diff #32985)

Use a switch

This revision now requires changes to proceed.Mar 30 2022, 17:18

Swapped checkboxes to switches

This revision is now accepted and ready to land.Mar 31 2022, 21:16