Page MenuHomePhabricator
Differential D11292

[avalanche] Fix an always true assertion in abc_p2p_getavaaddr
ClosedPublic
Actions

Authored by Fabien on Apr 1 2022, 08:58.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC53b215b63d80: [avalanche] Fix an always true assertion in abc_p2p_getavaaddr
Summary

There is a loop intended to check that we get one more message after each iteration, but it's always true after the first one due to poor condition check.

Test Plan
./test/functional/test_runner.py abc_p2p_getavaaddr

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_fix_abc_p2p_getavaaddr_msg_loop
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18708
Build 37207: Build Diffbuild-without-wallet · build-diff · build-clang-tidy · build-clang · build-debug
Build 37206: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 1 2022, 08:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 1 2022, 08:58
Fabien requested review of this revision.Apr 1 2022, 08:58
Fabien added a child revision: D11293: [avalanche] Use constants for delays in abc_p2p_getavaaddr.Apr 1 2022, 09:06
Harbormaster completed remote builds in B18708: Diff 33037.Apr 1 2022, 09:14
PiRK accepted this revision.Apr 1 2022, 12:49
PiRK added a subscriber: PiRK.
PiRK added inline comments.
test/functional/abc_p2p_getavaaddr.py
289

is the triple a intentional in the variable name?

This revision is now accepted and ready to land.Apr 1 2022, 12:49
Fabien added inline comments.Apr 1 2022, 13:00
test/functional/abc_p2p_getavaaddr.py
289

No it's not, good catch !

Closed by commit rABC53b215b63d80: [avalanche] Fix an always true assertion in abc_p2p_getavaaddr (authored by Fabien). · Explain WhyApr 1 2022, 13:01
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC53b215b63d80: [avalanche] Fix an always true assertion in abc_p2p_getavaaddr.

Revision Contents
Changeset List

PathSize
test/
functional/
9 lines

Diff 33037

View Options

test/functional/abc_p2p_getavaaddr.py

Loading...