Remove duplicated (and misplaced) node disconnection logging
ClosedPublic
Actions

Authored by Fabien on Apr 3 2022, 08:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC26e7529b03ec: Remove duplicated (and misplaced) node disconnection logging

Summary

This line was added at the wrong place in D3284, but was also added at the right place in D1749. This ends up being duplicated and confusing.

Test Plan

ninja all check

Check in the log there is no spurious Cleared nodestate message anymore.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

remove_duplicate_log

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18718
Build 37227: Build Diff	build-diff · lint-circular-dependencies · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 37226: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 3 2022, 08:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 3 2022, 08:58

Fabien requested review of this revision.Apr 3 2022, 08:58

Harbormaster completed remote builds in B18718: Diff 33054.Apr 3 2022, 09:15

PiRK accepted this revision.Apr 3 2022, 19:00

This revision is now accepted and ready to land.Apr 3 2022, 19:00

Closed by commit rABC26e7529b03ec: Remove duplicated (and misplaced) node disconnection logging (authored by Fabien). · Explain WhyApr 3 2022, 19:06

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC26e7529b03ec: Remove duplicated (and misplaced) node disconnection logging.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

1 line

Diff 33054

View Options

Remove duplicated (and misplaced) node disconnection loggingClosedPublicActions