As per title. As the whole number system is LE, I went went for LE encoding. This doesn't seems like a great idea to fubar the scrpipt system even more than it already is by introducing mixed endianess in it.
Details
Details
- Reviewers
jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING78075318d709: Add support for BIN2NUM opcode
rABC78075318d709: Add support for BIN2NUM opcode
Added various test cases.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- bin2num
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 2184 Build 2512: Bitcoin ABC Buildbot (legacy) Build 2511: arc lint + arc unit
Event Timeline
Comment Actions
Couple nits, then I think we're good to go
| src/test/monolith_opcodes.cpp | ||
|---|---|---|
| 355 ↗ | (On Diff #3312) | @schancel and I were hoping to split these tests up a bit. For BIN2NUM and NUM2BIN, please use monolith_opcodes_type.cpp (see https://reviews.bitcoinabc.org/D1103) |
| 415 ↗ | (On Diff #3312) | nifty |
| 418 ↗ | (On Diff #3312) | Mege -> Merge |
| src/test/monolith_opcodes.cpp | ||
|---|---|---|
| 355 ↗ | (On Diff #3312) | There is already a ton of reundancy in that code, so we want to factor that out at some point. It'll be easier in one file. |
| src/test/monolith_opcodes.cpp | ||
|---|---|---|
| 415 ↗ | (On Diff #3312) | That's elite programming right there XD |