Differential D11363

[avalanche] Don't ban peers sending us unsolicited avalanche messages
ClosedPublic
Actions

Authored by Fabien on Apr 15 2022, 08:54.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3b93fbd4fe78: [avalanche] Don't ban peers sending us unsolicited avalanche messages

Summary

This doesn't make sense to ban a peer for sending a message when some local option is missing, as there is no way for that peer to know about that. Just do the same than for any other message and ignore it.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_dont_ban_messages

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18833
Build 37456: Build Diff	build-without-wallet · build-diff · lint-circular-dependencies · build-clang-tidy · build-clang · build-debug
Build 37455: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 15 2022, 08:54

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 15 2022, 08:54

Fabien requested review of this revision.Apr 15 2022, 08:54

Harbormaster completed remote builds in B18833: Diff 33230.Apr 15 2022, 09:09

Fabien added a child revision: D11365: [avalanche] Always send an avahello message if we have a proof.Apr 15 2022, 10:58

PiRK accepted this revision.Apr 15 2022, 15:55

This revision is now accepted and ready to land.Apr 15 2022, 15:55

Closed by commit rABC3b93fbd4fe78: [avalanche] Don't ban peers sending us unsolicited avalanche messages (authored by Fabien). · Explain WhyApr 15 2022, 20:57

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3b93fbd4fe78: [avalanche] Don't ban peers sending us unsolicited avalanche messages.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

2 lines

test/

functional/

p2p_invalid_messages.py

24 lines

Diff 33230

src/net_processing.cpp

Loading...

test/functional/p2p_invalid_messages.py

Loading...