Differential D11368

Fix the osx build issue in the peer manager tests
ClosedPublic
Actions

Authored by Fabien on Apr 16 2022, 06:15.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC0778b92f3c63: Fix the osx build issue in the peer manager tests

Summary

The compiler doesn't like the variadic template arguments following an optional argument, so fix this.

Test Plan

On OSX:

ninja check-avalanche

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_osx_build

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 18839
Build 37468: Build Diff	build-without-wallet · build-diff · lint-circular-dependencies · build-clang · build-debug · build-clang-tidy
Build 37467: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 16 2022, 06:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 16 2022, 06:15

Fabien requested review of this revision.Apr 16 2022, 06:15

@bot build-osx

teamcity awarded a token.Apr 16 2022, 06:16

Harbormaster completed remote builds in B18839: Diff 33242.Apr 16 2022, 06:30

PiRK accepted this revision.Apr 16 2022, 20:22

This revision is now accepted and ready to land.Apr 16 2022, 20:22

Closed by commit rABC0778b92f3c63: Fix the osx build issue in the peer manager tests (authored by Fabien). · Explain WhyApr 16 2022, 20:56

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC0778b92f3c63: Fix the osx build issue in the peer manager tests.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

peermanager_tests.cpp

14 lines

Diff 33242

View Options

src/avalanche/test/peermanager_tests.cpp

Fix the osx build issue in the peer manager testsClosedPublicActions