Differential D1222

Implement support for NUM2BIN
ClosedPublic
Actions

Authored by deadalnix on Mar 21 2018, 05:38.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Maniphest Tasks

T310: Adds OP_NUM2BIN functionality into interpreter.cpp

Commits

rSTAGINGa30ddaf208ab: Implement support for NUM2BIN
rABCa30ddaf208ab: Implement support for NUM2BIN

Summary

As per title.

Test Plan

Ass json test cases and unit tests.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

num2bin

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 2193
Build 2530: Bitcoin ABC Buildbot (legacy)
Build 2529: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 21 2018, 05:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 21 2018, 05:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2188: Diff 3320.Mar 21 2018, 06:00

jasonbcox requested changes to this revision.Mar 21 2018, 06:40

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/test/data/script_tests.json
836 ↗	(On Diff #3320)	arguement -> argument for this and the other tests below
847 ↗	(On Diff #3320)	Needs a case for negative zero: ["-0 1", "NUM2BIN 0x00 EQUAL", "P2SH,STRICTENC,MONOLITH_OPCODES", "OK", "Negative zero extended as zero"],

This revision now requires changes to proceed.Mar 21 2018, 06:40

arguement
negative zero

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2193: Diff 3325.Mar 22 2018, 01:40

schancel accepted this revision.Mar 22 2018, 02:13

schancel removed a reviewer: jasonbcox.Mar 22 2018, 04:50

This revision is now accepted and ready to land.Mar 22 2018, 04:50

schancel added a task: T310: Adds OP_NUM2BIN functionality into interpreter.cpp.Mar 22 2018, 04:55

Closed by commit rABCa30ddaf208ab: Implement support for NUM2BIN (authored by deadalnix). · Explain WhyMar 22 2018, 05:06

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

script/

interpreter.cpp

47 lines

1 line

script_error.cpp

2 lines

test/

data/

script_tests.json

31 lines

monolith_opcodes.cpp

84 lines

Diff 3325

src/script/interpreter.cpp

Loading...

src/script/script_error.h

Loading...

src/script/script_error.cpp

Loading...

src/test/data/script_tests.json

Loading...

src/test/monolith_opcodes.cpp

Loading...