Differential D11395

[Cashtab] Add a saved wallet to contact list
ClosedPublic
Actions

Authored by emack on Apr 28 2022, 15:02.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABCb1b735eb8594: [Cashtab] Add a saved wallet to contact list

Summary

Ability to add a wallet in the Saved Wallets dropdown to the contact list.

Test Plan

npm start
open the saved wallets dropdown and click on the Contact icon, and then the OK button in the confirmation modal and verify wallet is successfully added to contacts
attempt to add the same saved wallet and verify duplication notification is displayed with no change to the contact list
change the name of this same saved wallet, attempt to add it from the saved wallet dropdown again and ensure the same duplication notification is displayed
change the name of the contact for this same saved wallet, attempt to add it from the saved wallet dropdown again and ensure the same duplication notification is displayed

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emack created this revision.Apr 28 2022, 15:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 28 2022, 15:02

emack requested review of this revision.Apr 28 2022, 15:02

Harbormaster completed remote builds in B18905: Diff 33341.Apr 28 2022, 15:05

bytesofman accepted this revision.Apr 28 2022, 20:38

This revision is now accepted and ready to land.Apr 28 2022, 20:38

pulling this back for a minor update - spotted a bug where adding a duplicate contact address from saved wallets correctly results in the duplication error but it does not clear the manual name/address state variables. This creates a downstream issue if the user then chooses to manually add a new contact, which contains the previous duplicate inputs and the user is forced to edit the name/address input fields before validation for the OK button passes.

emack requested review of this revision.May 1 2022, 11:14

Harbormaster completed remote builds in B18917: Diff 33361.May 1 2022, 11:16

bytesofman accepted this revision.May 2 2022, 16:36

This revision is now accepted and ready to land.May 2 2022, 16:36

Closed by commit rABCb1b735eb8594: [Cashtab] Add a saved wallet to contact list (authored by emack). · Explain WhyMay 3 2022, 11:18

This revision was automatically updated to reflect the committed changes.

emack added a commit: rABCb1b735eb8594: [Cashtab] Add a saved wallet to contact list.