Differential D11508

Move the Uint256RadixKey to its own header
ClosedPublic
Actions

Authored by Fabien on May 20 2022, 12:37.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rABC7ae13b812ffa: Move the Uint256RadixKey to its own header

Summary

The key doesn't need to know about the radix tree, and the radix tree doesn't need to know about the key.

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

radix_move_uint256key

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19120
Build 37988: Build Diff	build-diff · build-without-wallet · build-debug · lint-circular-dependencies · build-clang · build-clang-tidy
Build 37987: arc lint + arc unit

Event Timeline

Fabien created this revision.May 20 2022, 12:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 20 2022, 12:37

Fabien requested review of this revision.May 20 2022, 12:37

Harbormaster completed remote builds in B19120: Diff 33641.May 20 2022, 12:53

deadalnix accepted this revision.May 20 2022, 12:54

This revision is now accepted and ready to land.May 20 2022, 12:54

Closed by commit rABC7ae13b812ffa: Move the Uint256RadixKey to its own header (authored by Fabien). · Explain WhyMay 20 2022, 14:42

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC7ae13b812ffa: Move the Uint256RadixKey to its own header.

Revision Contents
Changeset List

Path

Size

src/

radix.h

21 lines

test/

radix_tests.cpp

1 line

uint256radixkey.h

34 lines

Diff 33641

View Options

src/radix.h

View Options

src/test/radix_tests.cpp

View Options

Move the Uint256RadixKey to its own headerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33641

src/radix.h

src/test/radix_tests.cpp

src/uint256radixkey.h

Move the Uint256RadixKey to its own header
ClosedPublic
Actions

Revision Contents
Changeset List