Page MenuHomePhabricator
Differential D11515

Move the DifferenceFormatter to serialize.h
ClosedPublic
Actions

Authored by Fabien on May 23 2022, 15:35.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC83f1192427f4: Move the DifferenceFormatter to serialize.h
Summary

This formatter will be used for the compact proofs as well. Also added some unit tests.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 23 2022, 15:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 23 2022, 15:35
Fabien requested review of this revision.May 23 2022, 15:35
Harbormaster completed remote builds in B19140: Diff 33669.May 23 2022, 15:49
PiRK accepted this revision.May 23 2022, 16:07
PiRK added a subscriber: PiRK.

Thanks for adding the documentation.

This revision is now accepted and ready to land.May 23 2022, 16:07
Fabien planned changes to this revision.May 23 2022, 18:24
Fabien added inline comments.
src/test/serialize_tests.cpp
487 ↗(On Diff #33669)

need to remove the magic number (it is overflow)

Fabien updated this revision to Diff 33676.May 23 2022, 18:45

Removing missed magic number

This revision is now accepted and ready to land.May 23 2022, 18:45
Fabien added a child revision: D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.May 23 2022, 18:56
Harbormaster completed remote builds in B19141: Diff 33676.May 23 2022, 19:15
Closed by commit rABC83f1192427f4: Move the DifferenceFormatter to serialize.h (authored by Fabien). · Explain WhyMay 23 2022, 19:20
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC83f1192427f4: Move the DifferenceFormatter to serialize.h.
Fabien removed a child revision: D11453: [avalanche] Introduce a CompactProofs class for managing the short proof ids.May 24 2022, 14:29
Fabien mentioned this in D11567: Fix off by one errors in the difference fomatter serialize_tests.Jun 3 2022, 18:58
Fabien mentioned this in rABCb903236dd018: Fix off by one errors in the difference fomatter serialize_tests.Jun 3 2022, 21:26

Revision Contents
Changeset List

PathSize
src/
24 lines
33 lines
test/
58 lines

Diff 33680

View Options

src/blockencodings.h

Loading...
View Options

src/serialize.h

Loading...
View Options

src/test/serialize_tests.cpp

Loading...