Page MenuHomePhabricator
Differential D11503

[avalanche] Set voterecord_tests node ID using a fixture
ClosedPublic
Actions

Authored by sdulfari on May 19 2022, 23:40.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4b68caf7e306: [avalanche] Set voterecord_tests node ID using a fixture
Summary

This puts shared init code for each test in a common fixture and clarifies some naming.

Depends on D11502

Test Plan
ninja check-avalanche

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sdulfari created this revision.May 19 2022, 23:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 19 2022, 23:40
sdulfari requested review of this revision.May 19 2022, 23:40
Harbormaster completed remote builds in B19115: Diff 33636.May 19 2022, 23:56
Fabien requested changes to this revision.May 20 2022, 09:57
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/avalanche/test/voterecord_tests.cpp
13 ↗(On Diff #33636)

You don't need the TestingSetup at all, just replace it

This revision now requires changes to proceed.May 20 2022, 09:57
sdulfari updated this revision to Diff 33652.May 21 2022, 05:26
  • Rebase on changes in D11502
  • Remove TestingSetup. It's not needed.
Harbormaster completed remote builds in B19129: Diff 33652.May 21 2022, 05:42
deadalnix accepted this revision.May 21 2022, 23:32
Fabien accepted this revision.May 23 2022, 08:06
This revision is now accepted and ready to land.May 23 2022, 08:06
Closed by commit rABC4b68caf7e306: [avalanche] Set voterecord_tests node ID using a fixture (authored by sdulfari). · Explain WhyMay 24 2022, 22:57
This revision was automatically updated to reflect the committed changes.
sdulfari added a commit: rABC4b68caf7e306: [avalanche] Set voterecord_tests node ID using a fixture.

Revision Contents
Changeset List

PathSize
src/
avalanche/
test/
46 lines

Diff 33691

View Options

src/avalanche/test/voterecord_tests.cpp

Loading...