Page MenuHomePhabricator
Differential D11557

refactor: Improve use of explicit keyword
ClosedPublic
Actions

Authored by PiRK on Jun 2 2022, 14:40.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC6922a8e02b08: refactor: Improve use of explicit keyword
Summary

Notes:

  • the linter part of the code is not applicable. We got rid of that linter in D11063 as it was obviously not very good at its job.
  • most of the work was already done in D6549
  • some of these constructors have two parameters in Bitcoin ABC

This is a backport of core#20530
https://github.com/bitcoin/bitcoin/pull/20530/commits/1e62350ca20898189904a88dfef9ea11ddcd8626

Test Plan

with clang and gcc
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
interfaces/
2 lines
6 lines
rpc/
2 lines
script/
2 lines
test/
fuzz/
2 lines
4 lines
util/
2 lines
wallet/
2 lines
4 lines

Diff 33800

View Options

src/interfaces/node.cpp

Loading...
View Options

src/invrequest.cpp

Loading...
View Options

src/rpc/request.h

Loading...
View Options

src/script/descriptor.cpp

Loading...
View Options

src/test/fuzz/signature_checker.cpp

Loading...
View Options

src/tinyformat.h

Loading...
View Options

src/util/hash_type.h

Loading...
View Options

src/wallet/bdb.h

Loading...
View Options

src/wallet/scriptpubkeyman.h

Loading...