Differential D11575

[avalanche] Respond to missing proof indices request
ClosedPublic
Actions

Authored by Fabien on Jun 7 2022, 12:49.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC4737c56915cc: [avalanche] Respond to missing proof indices request

Summary

Retrieve missing proofs by matching the requested indices against the stored proof radix tree for the requesting peer. The proofs are sent with individual avaproof messages so we don't have to care about the message being oversized. The radix tree is nulled after this so we only process the requests one at a time.

Depends on D11545.

Test Plan

ninja check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_send_requested_proofs

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19301
Build 38342: Build Diff	build-without-wallet · build-debug · lint-circular-dependencies · build-clang-tidy · build-diff · build-clang
Build 38341: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 7 2022, 12:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2022, 12:49

Fabien requested review of this revision.Jun 7 2022, 12:49

Harbormaster completed remote builds in B19284: Diff 33858.Jun 7 2022, 13:00

deadalnix accepted this revision.Jun 7 2022, 23:22

This revision is now accepted and ready to land.Jun 7 2022, 23:22

deadalnix added inline comments.Jun 7 2022, 23:22

src/net_processing.cpp
5306 ↗	(On Diff #33858)	This obviously will need to be updated.

Rebase, no more smart pointer.
The special case for unsollicited message is now removed, but the behavior is the same (no proof is sent).

Harbormaster completed remote builds in B19301: Diff 33890.Jun 8 2022, 09:32

Closed by commit rABC4737c56915cc: [avalanche] Respond to missing proof indices request (authored by Fabien). · Explain WhyJun 9 2022, 07:28

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4737c56915cc: [avalanche] Respond to missing proof indices request.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

32 lines

test/

functional/

abc_p2p_compactproofs.py

141 lines

Diff 33890

src/net_processing.cpp

Loading...

test/functional/abc_p2p_compactproofs.py

Loading...