Page MenuHomePhabricator

[avalanche] Respond to missing proof indices request
ClosedPublic

Authored by Fabien on Jun 7 2022, 12:49.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC4737c56915cc: [avalanche] Respond to missing proof indices request
Summary

Retrieve missing proofs by matching the requested indices against the stored proof radix tree for the requesting peer. The proofs are sent with individual avaproof messages so we don't have to care about the message being oversized. The radix tree is nulled after this so we only process the requests one at a time.

Depends on D11545.

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_send_requested_proofs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19301
Build 38342: Build Diffbuild-without-wallet · build-debug · lint-circular-dependencies · build-clang-tidy · build-diff · build-clang
Build 38341: arc lint + arc unit

Event Timeline

Fabien requested review of this revision.Jun 7 2022, 12:49
This revision is now accepted and ready to land.Jun 7 2022, 23:22
src/net_processing.cpp
5306 ↗(On Diff #33858)

This obviously will need to be updated.

Rebase, no more smart pointer.
The special case for unsollicited message is now removed, but the behavior is the same (no proof is sent).