Page MenuHomePhabricator
Differential D11574

Leverage Empty Base Optimization for the radix tree Adapter
ClosedPublic
Actions

Authored by Fabien on Jun 7 2022, 09:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC15657f04c74d: Leverage Empty Base Optimization for the radix tree Adapter
Summary

As per title, see https://en.cppreference.com/w/cpp/language/ebo.
Suggested by @deadalnix in D11571.

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Jun 7 2022, 09:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 7 2022, 09:48
Fabien requested review of this revision.Jun 7 2022, 09:48
Harbormaster completed remote builds in B19283: Diff 33857.Jun 7 2022, 10:04
deadalnix requested changes to this revision.Jun 8 2022, 14:11
deadalnix added inline comments.
src/radix.h
40 ↗(On Diff #33857)

private

This revision now requires changes to proceed.Jun 8 2022, 14:11
Fabien updated this revision to Diff 33892.Jun 8 2022, 14:22

RadixTree is a struct, so it needs to explicitely set the base class private

Harbormaster completed remote builds in B19303: Diff 33892.Jun 8 2022, 14:37
deadalnix accepted this revision.Jun 8 2022, 22:37
This revision is now accepted and ready to land.Jun 8 2022, 22:37
Closed by commit rABC15657f04c74d: Leverage Empty Base Optimization for the radix tree Adapter (authored by Fabien). · Explain WhyJun 9 2022, 07:10
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC15657f04c74d: Leverage Empty Base Optimization for the radix tree Adapter.

Revision Contents
Changeset List

PathSize
src/
5 lines

Diff 33892

View Options

src/radix.h

Loading...