Page MenuHomePhabricator
Differential D1246

Remove reclarations of read_json, create a dedicated header instead
ClosedPublic
Actions

Authored by deadalnix on Apr 5 2018, 12:38.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING1e98fdfb6b0b: Remove reclarations of read_json, create a dedicated header instead
rABC1e98fdfb6b0b: Remove reclarations of read_json, create a dedicated header instead
Summary

As per title. Declaring things at a distance makes the code hard to follow and fragile.

Test Plan
make check
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Branch
reaj_jsonrefac
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2239
Build 2621: Bitcoin ABC Buildbot (legacy)
Build 2620: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 5 2018, 12:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2018, 12:38
deadalnix added a parent revision: D1244: Add support to build json test using cmake.Apr 5 2018, 12:38
teamcity added a subscriber: teamcity.Apr 5 2018, 13:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 5 2018, 13:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 5 2018, 13:33

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2239: Diff 3393!Apr 5 2018, 13:33
deadalnix added a child revision: D1247: Refactor wallet tests as built by cmake.Apr 5 2018, 14:02
deadalnix removed a child revision: D1247: Refactor wallet tests as built by cmake.Apr 6 2018, 12:45
deadalnix added a child revision: D1248: Add support to run the test suite via ninja.Apr 6 2018, 17:59
schancel accepted this revision.Apr 8 2018, 14:40
schancel retitled this revision from Remove redclarations of read_json, create a dedicated header instead to Remove reclarations of read_json, create a dedicated header instead.
This revision is now accepted and ready to land.Apr 8 2018, 14:42
Closed by commit rABC1e98fdfb6b0b: Remove reclarations of read_json, create a dedicated header instead (authored by deadalnix). · Explain WhyApr 8 2018, 14:50
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 3393

View Options

src/Makefile.test.include

Loading...
View Options

src/test/CMakeLists.txt

Loading...
View Options

src/test/base58_tests.cpp

Loading...
View Options

src/test/jsonutil.h

Loading...
View Options

src/test/jsonutil.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/sighash_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...