test: Add tests for block_info in gettxoutsetinfo
ClosedPublic
Actions

Authored by PiRK on Jun 10 2022, 09:27.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa6842135a4cc: test: Add tests for block_info in gettxoutsetinfo

Summary

This is a backport of core#19521 [12/17]
https://github.com/bitcoin/bitcoin/pull/19521/commits/e0938c29099635150014ffc9bb0cafa8049ec55a

Note that there are minor differences in some amounts compared to the source commit due to differences in tx fees.

Depends on D11605

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19345
Build 38427: Build Diff	build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 38426: arc lint + arc unit

Event Timeline

PiRK created this revision.Jun 10 2022, 09:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 10 2022, 09:27

PiRK requested review of this revision.Jun 10 2022, 09:27

teamcity edited the summary of this revision. (Show Details)Jun 10 2022, 09:27

PiRK added a child revision: D11607: test: Test coinstatsindex robustness across restarts.Jun 10 2022, 09:29

Harbormaster completed remote builds in B19345: Diff 33952.Jun 10 2022, 09:56

Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Failed tests logs:

====== Bitcoin ABC functional tests: abc_p2p_proof_inventory.py ======

------- Stdout: -------
2022-06-10T09:54:33.801000Z TestFramework (INFO): Initializing test directory /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220610_095338/abc_p2p_proof_inventory_27
2022-06-10T09:54:34.364000Z TestFramework (INFO): Test sending a proof to our peers
2022-06-10T09:54:35.485000Z TestFramework (INFO): Test that we don't send the same inv several times
2022-06-10T09:54:36.210000Z TestFramework (INFO): Test a peer is created on proof reception
2022-06-10T09:54:36.341000Z TestFramework (INFO): Test receiving a proof with missing utxo is orphaned
2022-06-10T09:54:42.592000Z TestFramework (INFO): Nodes should eventually get the proof from their peer
2022-06-10T09:55:43.330000Z TestFramework (ERROR): Assertion failed
Traceback (most recent call last):
  File "/work/test/functional/test_framework/test_framework.py", line 136, in main
    self.run_test()
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 341, in run_test
    self.test_proof_relay()
  File "/work/test/functional/abc_p2p_proof_inventory.py", line 179, in test_proof_relay
    self.sync_proofs()
  File "/work/test/functional/test_framework/test_framework.py", line 668, in sync_proofs
    "".join("\n  {!r}".format(m) for m in nodes_proofs),
AssertionError: Proofs sync timed out after 60s:
  {'494543a4064c1a5302e043ae108880fd20b3e17047c1ee2cf58a9cc0bdcada45'}
  {'5eebf4d7059912c992d5421660e805a1628b4645e8b3cfc07d22165682fc0b02', '2a3636f16556f1616b5bed870f124c7eed9ef576b2b0e152e01e2311af972e97', '99e02638aec1352a3457bd1f038354de637954d4e673b6a3054606d1f7acd8a9', 'dee8451cc6b6b0dd3e88845ca7f4a311ab69ab5c9aa25eebbe9756d2ced91f38'}
  {'5eebf4d7059912c992d5421660e805a1628b4645e8b3cfc07d22165682fc0b02', '2a3636f16556f1616b5bed870f124c7eed9ef576b2b0e152e01e2311af972e97', '99e02638aec1352a3457bd1f038354de637954d4e673b6a3054606d1f7acd8a9', 'dee8451cc6b6b0dd3e88845ca7f4a311ab69ab5c9aa25eebbe9756d2ced91f38'}
  {'5eebf4d7059912c992d5421660e805a1628b4645e8b3cfc07d22165682fc0b02', '2a3636f16556f1616b5bed870f124c7eed9ef576b2b0e152e01e2311af972e97', '99e02638aec1352a3457bd1f038354de637954d4e673b6a3054606d1f7acd8a9', 'dee8451cc6b6b0dd3e88845ca7f4a311ab69ab5c9aa25eebbe9756d2ced91f38'}
  {'5eebf4d7059912c992d5421660e805a1628b4645e8b3cfc07d22165682fc0b02', '2a3636f16556f1616b5bed870f124c7eed9ef576b2b0e152e01e2311af972e97', '99e02638aec1352a3457bd1f038354de637954d4e673b6a3054606d1f7acd8a9', 'dee8451cc6b6b0dd3e88845ca7f4a311ab69ab5c9aa25eebbe9756d2ced91f38'}
2022-06-10T09:55:43.380000Z TestFramework (INFO): Stopping nodes
2022-06-10T09:55:43.635000Z TestFramework (WARNING): Not cleaning up dir /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220610_095338/abc_p2p_proof_inventory_27
2022-06-10T09:55:43.635000Z TestFramework (ERROR): Test failed. Test logging available at /work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220610_095338/abc_p2p_proof_inventory_27/test_framework.log
2022-06-10T09:55:43.635000Z TestFramework (ERROR): 
2022-06-10T09:55:43.635000Z TestFramework (ERROR): Hint: Call /work/test/functional/combine_logs.py '/work/abc-ci-builds/build-without-wallet/test/tmp/test_runner_₿₵_  _20220610_095338/abc_p2p_proof_inventory_27' to consolidate all logs
2022-06-10T09:55:43.635000Z TestFramework (ERROR): 
2022-06-10T09:55:43.635000Z TestFramework (ERROR): If this failure happened unexpectedly or intermittently, please file a bug and provide a link or upload of the combined log.
2022-06-10T09:55:43.635000Z TestFramework (ERROR): https://github.com/Bitcoin-ABC/bitcoin-abc/issues
2022-06-10T09:55:43.635000Z TestFramework (ERROR):

Each failure log is accessible here:
Bitcoin ABC functional tests: abc_p2p_proof_inventory.py

Fabien accepted this revision.Jun 10 2022, 23:21

This revision is now accepted and ready to land.Jun 10 2022, 23:21

This revision was landed with ongoing or failed builds.Jun 13 2022, 18:28

Closed by commit rABCa6842135a4cc: test: Add tests for block_info in gettxoutsetinfo (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain Why

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa6842135a4cc: test: Add tests for block_info in gettxoutsetinfo.