Page MenuHomePhabricator
Differential D11667

[avalanche] Run the proofs cleanup on a schedule
ClosedPublic
Actions

Authored by Fabien on Jun 24 2022, 15:38.

Details

Reviewers
sdulfari
Group Reviewers
Restricted Project
Commits
rABCd9578a9219ed: [avalanche] Run the proofs cleanup on a schedule
Summary

This diffs runs the dangling proofs cleanup every 5 minutes and add tests for it.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_run_periodic_maintenance
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19474
Build 38681: Build Difflint-circular-dependencies · build-without-wallet · build-debug · build-diff · build-clang-tidy · build-clang
Build 38680: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 24 2022, 15:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 24 2022, 15:38
Fabien requested review of this revision.Jun 24 2022, 15:38
Harbormaster completed remote builds in B19468: Diff 34128.Jun 24 2022, 16:21
sdulfari requested changes to this revision.Jun 24 2022, 19:43
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/avalanche/peermanager.h
229 ↗(On Diff #34128)

Unused?

test/functional/abc_feature_proof_cleanup.py
29 ↗(On Diff #34128)

I recently landed D11622 so you'll probably need to add '-avaproofstakeutxoconfirmations=1',

This revision now requires changes to proceed.Jun 24 2022, 19:43
Fabien added inline comments.Jun 24 2022, 20:39
src/avalanche/peermanager.h
229 ↗(On Diff #34128)

Good catch, leftover from another code

Fabien edited the summary of this revision. (Show Details)Jun 24 2022, 20:39
Fabien updated this revision to Diff 34137.Jun 24 2022, 20:41
  • Rebase, update the funcional test accordingly and run it with --nolegacyavaproof
  • Remove leftover
  • Remove spurious ; in the peermanager unit test
sdulfari accepted this revision.Jun 24 2022, 20:54
This revision is now accepted and ready to land.Jun 24 2022, 20:54
Harbormaster completed remote builds in B19474: Diff 34137.Jun 24 2022, 21:01
Closed by commit rABCd9578a9219ed: [avalanche] Run the proofs cleanup on a schedule (authored by Fabien). · Explain WhyJun 25 2022, 16:39
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd9578a9219ed: [avalanche] Run the proofs cleanup on a schedule.

Revision Contents
Changeset List

PathSize
src/
avalanche/
4 lines
9 lines
6 lines
15 lines
test/
52 lines
15 lines
2 lines
2 lines
test/
functional/
96 lines
1 line

Diff 34137

View Options

src/avalanche/peermanager.h

Loading...
View Options

src/avalanche/peermanager.cpp

Loading...
View Options

src/avalanche/processor.h

Loading...
View Options

src/avalanche/processor.cpp

Loading...
View Options

src/avalanche/test/peermanager_tests.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/avalanche/test/proofpool_tests.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

test/functional/abc_feature_proof_cleanup.py

Loading...
View Options

test/functional/test_runner.py

Loading...