[Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ensuring rustfmt when installing nightly
ClosedPublic
Actions

Authored by tobias_ruck on Jul 5 2022, 23:23.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC41e5512254bf: [Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ensuring…

Summary

On some machines, the current set of commands won't necessarily install the rustfmt component.

Adding this call to both CONTRIBUTING.md and install-dependencies.sh doesn't error when rustfmt is already there, but will install it if it isn't.

Test Plan

Run the commands in e.g. a clean docker environment, will either install rustfmt or output info: component 'rustfmt' for target '<target>' is up to date

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19575
Build 38869: Build Diff
Build 38868: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jul 5 2022, 23:23

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 5 2022, 23:23

tobias_ruck requested review of this revision.Jul 5 2022, 23:23

Harbormaster completed remote builds in B19568: Diff 34262.Jul 5 2022, 23:23

Add the same commands to install-dependencies.sh

Harbormaster completed remote builds in B19575: Diff 34273.Jul 6 2022, 09:12

tobias_ruck retitled this revision from [Chronik] Add line ensuring rustfmt when installing nightly to [Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ensuring rustfmt when installing nightly.Jul 6 2022, 09:15

tobias_ruck edited the summary of this revision. (Show Details)

tobias_ruck edited the test plan for this revision. (Show Details)

Fabien accepted this revision.Jul 6 2022, 12:10

This revision is now accepted and ready to land.Jul 6 2022, 12:10

Closed by commit rABC41e5512254bf: [Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ensuring… (authored by tobias_ruck). · Explain WhyJul 6 2022, 12:18

This revision was automatically updated to reflect the committed changes.

tobias_ruck added a commit: rABC41e5512254bf: [Chronik] Add line to CONTRIBUTING.md and install-dependencies.sh ensuring….