Differential D11722

[avalanche] Remove unused hash verifier in avahello deserialization
ClosedPublic
Actions

Authored by Fabien on Jul 6 2022, 13:58.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC4a74d3717a8b: [avalanche] Remove unused hash verifier in avahello deserialization

Summary

This has never been used and compute a hash of the message for no reason. There is no change in behavior.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_avahello_no_hashverifier

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19578
Build 38875: Build Diff	build-without-wallet · build-debug · build-diff · build-clang-tidy · lint-circular-dependencies · build-clang
Build 38874: arc lint + arc unit

Event Timeline

Fabien created this revision.Jul 6 2022, 13:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 6 2022, 13:58

Fabien requested review of this revision.Jul 6 2022, 13:58

Harbormaster completed remote builds in B19578: Diff 34277.Jul 6 2022, 14:17

PiRK accepted this revision.Jul 6 2022, 14:34

This revision is now accepted and ready to land.Jul 6 2022, 14:34

Closed by commit rABC4a74d3717a8b: [avalanche] Remove unused hash verifier in avahello deserialization (authored by Fabien). · Explain WhyJul 6 2022, 16:13

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC4a74d3717a8b: [avalanche] Remove unused hash verifier in avahello deserialization.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

5 lines

Diff 34277

View Options

[avalanche] Remove unused hash verifier in avahello deserializationClosedPublicActions