Differential D11778

[refactor] clean up logic in testmempoolaccept
ClosedPublic
Actions

Authored by PiRK on Jul 21 2022, 09:58.

Details

Reviewers

sdulfari

Group Reviewers

Restricted Project

Commits

rABC9c234285e9a8: [refactor] clean up logic in testmempoolaccept

Summary

Cleans up reundant code and reduces the diff of the next commit.

This is a backport of core#21062 [1/4]
https://github.com/bitcoin/bitcoin/pull/21062/commits/9db10a55061e09021ff8ea1d6637d99f7959035f

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19683
Build 39085: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang · build-clang-tidy
Build 39084: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 21 2022, 09:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2022, 09:58

PiRK requested review of this revision.Jul 21 2022, 09:58

teamcity edited the summary of this revision. (Show Details)Jul 21 2022, 09:58

PiRK added a child revision: D11779: [refactor] return MempoolAcceptResult.Jul 21 2022, 10:05

Harbormaster completed remote builds in B19683: Diff 34448.Jul 21 2022, 10:15

sdulfari accepted this revision.Jul 21 2022, 18:06

This revision is now accepted and ready to land.Jul 21 2022, 18:06

Closed by commit rABC9c234285e9a8: [refactor] clean up logic in testmempoolaccept (authored by gzhao408 <gzhao408@berkeley.edu>, committed by PiRK). · Explain WhyJul 22 2022, 06:53

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9c234285e9a8: [refactor] clean up logic in testmempoolaccept.

Revision Contents
Changeset List

Path

Size

src/

rpc/

rawtransaction.cpp

42 lines

Diff 34448

View Options

src/rpc/rawtransaction.cpp

[refactor] clean up logic in testmempoolacceptClosedPublicActions