Page MenuHomePhabricator
Differential D11811

[Chronik] Add /chronik to existing lints
ClosedPublic
Actions

Authored by tobias_ruck on Jul 27 2022, 18:37.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa1f02d1b803a: [Chronik] Add /chronik to existing lints
Summary

There's a lot of lints ran on /src, we also want them to be run on /chronik.

Test Plan

arc lint, shouldn't break anything

Diff Detail

Repository
rABC Bitcoin ABC
Branch
chronik-lint
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19741
Build 39201: Build Diff
Build 39200: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Jul 27 2022, 18:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 27 2022, 18:37
tobias_ruck requested review of this revision.Jul 27 2022, 18:37
Harbormaster completed remote builds in B19741: Diff 34538.Jul 27 2022, 18:37
Fabien requested changes to this revision.Jul 27 2022, 19:45
Fabien added inline comments.
.arclint
91

I'm sure there might be spelling issues in chronik as well, even in the rust code

238

This one is interesting also

This revision now requires changes to proceed.Jul 27 2022, 19:45
Fabien added inline comments.Jul 27 2022, 19:47
.arclint
91

NVM it's already there

tobias_ruck updated this revision to Diff 34649.Aug 13 2022, 10:01

Added whitespace check

Harbormaster completed remote builds in B19816: Diff 34649.Aug 13 2022, 10:01
Fabien accepted this revision.Aug 15 2022, 16:13
This revision is now accepted and ready to land.Aug 15 2022, 16:13
Closed by commit rABCa1f02d1b803a: [Chronik] Add /chronik to existing lints (authored by tobias_ruck). · Explain WhyAug 15 2022, 21:03
This revision was automatically updated to reflect the committed changes.
tobias_ruck added a commit: rABCa1f02d1b803a: [Chronik] Add /chronik to existing lints.

Revision Contents
Changeset List

PathSize
32 lines

Diff 34538

View Options

.arclint

Loading...