Page MenuHomePhabricator
Differential D1269

Rename Bitcoin to Bitcoin Cash in GUI & translation files
AbandonedPublic
Actions

Authored by andychen on Apr 9 2018, 15:14.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Some of the Bitcoin words should be renamed to Bitcoin Cash, however words such as BicoinABC & BitcoinGUI should not.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature/rename_bitcoin_to_bitcoincash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2283
Build 2704: Bitcoin ABC Buildbot (legacy)
Build 2703: arc lint + arc unit

Event Timeline

andychen created this revision.Apr 9 2018, 15:14
Owners added a reviewer: Restricted Owners Package.Apr 9 2018, 15:14
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptApr 9 2018, 15:14
teamcity added a subscriber: teamcity.Apr 9 2018, 15:51

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel accepted this revision.Apr 9 2018, 15:58
schancel retitled this revision from rename Bitcoin to Bitcoin Cash in GUI & translation files to Rename Bitcoin to Bitcoin Cash in GUI & translation files.
schancel edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 9 2018, 15:58
Harbormaster completed remote builds in B2278: Diff 3447.Apr 9 2018, 16:09
teamcity added a comment.Apr 9 2018, 16:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

deadalnix requested changes to this revision.Apr 9 2018, 22:35
deadalnix added a subscriber: deadalnix.

This wasn't the code that was accepted, and for good reason (this breaks various translations).

This revision now requires changes to proceed.Apr 9 2018, 22:35
andychen added a comment.Apr 10 2018, 00:11
In D1269#25022, @deadalnix wrote:

This wasn't the code that was accepted, and for good reason (this breaks various translations).

which translations, I can fix it.

andychen added a comment.Apr 10 2018, 00:17

"Enter a Bitcoin address" this translation is broken, trying to find more.

andychen updated this revision to Diff 3463.Apr 10 2018, 01:08

some of the Bitcoin should be replaced to Bitcoin Cash in gui cpp files.

teamcity added a comment.Apr 10 2018, 01:09

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel requested changes to this revision.Apr 10 2018, 01:12

Thank you for your effort on this. In order to make sure this commit is valuable and works, can you please make sure that you are updating the references to the translations at the same time that you fix the translations?

src/qt/locale/bitcoin_af.ts
65

The reference to this translation does not seem to be updated?

313

I'm not seeing where this is referenced in the code?

341

This one also does not seem to be updated in the cpp files?

This revision now requires changes to proceed.Apr 10 2018, 01:12
andychen updated this revision to Diff 3464.Apr 10 2018, 01:16

modify 'These are your Bitcoin Cash addresses'

teamcity added a comment.Apr 10 2018, 01:26

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

andychen updated this revision to Diff 3465.Apr 10 2018, 01:31
andychen marked an inline comment as done.

rename Bitcoin to Bitcoin Cash in cpp files work with translation

andychen added a comment.Apr 10 2018, 01:33

more translation found:

src/qt/editaddressdialog.cpp
src/qt/guiutil.cpp

src/qt/forms/ui_signverifymessagedialog.h (This is gitignored)

src/qt/locale/bitcoin_af.ts
65

fixed.

313

tr("Bitcoin") in 929 of bitconigui.cpp file, will be fixed

341

fixed.

teamcity added a comment.Apr 10 2018, 01:41

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

schancel added inline comments.Apr 10 2018, 01:51
src/qt/guiutil.cpp
166 ↗(On Diff #3465)

Doesn't seem to be in the translations?

andychen added inline comments.Apr 10 2018, 01:53
src/qt/locale/bitcoin_bg.ts
1139 ↗(On Diff #3465)

here it is

schancel added inline comments.Apr 10 2018, 01:56
src/qt/locale/bitcoin_ca.ts
2068 ↗(On Diff #3465)

Where is the code that references this updated?

andychen updated this revision to Diff 3466.Apr 10 2018, 01:59

fix translation in 'Warning: Invalid Bitcoin Cash address'

andychen added inline comments.Apr 10 2018, 02:00
src/qt/locale/bitcoin_ca.ts
2068 ↗(On Diff #3465)

fixed.

teamcity added a comment.Apr 10 2018, 02:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 10 2018, 02:00

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2283: Diff 3463.Apr 10 2018, 02:02
teamcity added a comment.Apr 10 2018, 02:15

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

teamcity added a comment.Apr 10 2018, 02:19

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

teamcity added a comment.Apr 10 2018, 02:19

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging started.

Harbormaster completed remote builds in B2284: Diff 3464.Apr 10 2018, 02:20
teamcity added a comment.Apr 10 2018, 02:34

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging failed.

Harbormaster failed remote builds in B2285: Diff 3465!Apr 10 2018, 02:35
teamcity added a comment.Apr 10 2018, 02:38

Build Bitcoin-ABC :: Staging :: Bitcoin-ABC Staging passed.

Harbormaster completed remote builds in B2286: Diff 3466.Apr 10 2018, 02:38
deadalnix requested changes to this revision.Apr 10 2018, 13:14

There was a diff that was accepted with a set of changes. If you want to do more, do other diffs.

This revision now requires changes to proceed.Apr 10 2018, 13:14
andychen added a comment.Apr 11 2018, 03:02
In D1269#25085, @deadalnix wrote:

There was a diff that was accepted with a set of changes. If you want to do more, do other diffs.

so, we should not amend the diff even if it's not accepted yet?

I keep in touch with Shammah Chancellor in this Diff, and fix those stuff, and he told me that I can amend the diff to this commit.

andychen abandoned this revision.Apr 11 2018, 15:26

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
2 lines
2 lines
locale/
24 lines
4 lines
26 lines
12 lines
32 lines
4 lines
100 lines
80 lines
100 lines
62 lines
6 lines
100 lines
120 lines
48 lines
70 lines
76 lines
20 lines
102 lines
14 lines
8 lines
34 lines
102 lines
14 lines
8 lines
16 lines
60 lines
4 lines
10 lines
30 lines
4 lines
84 lines
102 lines
24 lines
34 lines
32 lines
2 lines
28 lines
38 lines
40 lines
90 lines
100 lines
34 lines
2 lines
46 lines
4 lines
32 lines
18 lines
32 lines
4 lines
2 lines
12 lines
80 lines
6 lines
98 lines
26 lines
76 lines
86 lines
66 lines
16 lines
60 lines
98 lines
2 lines
90 lines
60 lines
14 lines
2 lines
8 lines
86 lines
6 lines
40 lines
110 lines
64 lines
28 lines
20 lines
2 lines
50 lines
16 lines
100 lines

Diff 3463

View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/editaddressdialog.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/locale/bitcoin_af.ts

Loading...
View Options

src/qt/locale/bitcoin_af_ZA.ts

Loading...
View Options

src/qt/locale/bitcoin_ar.ts

Loading...
View Options

src/qt/locale/bitcoin_be_BY.ts

Loading...
View Options

src/qt/locale/bitcoin_bg.ts

Loading...
View Options

src/qt/locale/bitcoin_bg_BG.ts

Loading...
View Options

src/qt/locale/bitcoin_ca.ts

Loading...
View Options

src/qt/locale/bitcoin_ca@valencia.ts

Loading...
View Options

src/qt/locale/bitcoin_ca_ES.ts

Loading...
View Options

src/qt/locale/bitcoin_cs.ts

Loading...
View Options

src/qt/locale/bitcoin_cy.ts

Loading...
View Options

src/qt/locale/bitcoin_da.ts

Loading...
View Options

src/qt/locale/bitcoin_de.ts

Loading...
View Options

src/qt/locale/bitcoin_el_GR.ts

Loading...
View Options

src/qt/locale/bitcoin_en.ts

Loading...
View Options

src/qt/locale/bitcoin_en_GB.ts

Loading...
View Options

src/qt/locale/bitcoin_eo.ts

Loading...
View Options

src/qt/locale/bitcoin_es.ts

Loading...
View Options

src/qt/locale/bitcoin_es_CL.ts

Loading...
View Options

src/qt/locale/bitcoin_es_CO.ts

Loading...
View Options

src/qt/locale/bitcoin_es_DO.ts

Loading...
View Options

src/qt/locale/bitcoin_es_ES.ts

Loading...
View Options

src/qt/locale/bitcoin_es_MX.ts

Loading...
View Options

src/qt/locale/bitcoin_es_UY.ts

Loading...
View Options

src/qt/locale/bitcoin_es_VE.ts

Loading...
View Options

src/qt/locale/bitcoin_et.ts

Loading...
View Options

src/qt/locale/bitcoin_et_EE.ts

Loading...
View Options

src/qt/locale/bitcoin_eu_ES.ts

Loading...
View Options

src/qt/locale/bitcoin_fa.ts

Loading...
View Options

src/qt/locale/bitcoin_fa_IR.ts

Loading...
View Options

src/qt/locale/bitcoin_fi.ts

Loading...
View Options

src/qt/locale/bitcoin_fr.ts

Loading...
View Options

src/qt/locale/bitcoin_fr_FR.ts

Loading...
View Options

src/qt/locale/bitcoin_gl.ts

Loading...
View Options

src/qt/locale/bitcoin_he.ts

Loading...
View Options

src/qt/locale/bitcoin_hi_IN.ts

Loading...
View Options

src/qt/locale/bitcoin_hr.ts

Loading...
View Options

src/qt/locale/bitcoin_hu.ts

Loading...
View Options

src/qt/locale/bitcoin_id_ID.ts

Loading...
View Options

src/qt/locale/bitcoin_it.ts

Loading...
View Options

src/qt/locale/bitcoin_ja.ts

Loading...
View Options

src/qt/locale/bitcoin_ka.ts

Loading...
View Options

src/qt/locale/bitcoin_kk_KZ.ts

Loading...
View Options

src/qt/locale/bitcoin_ko_KR.ts

Loading...
View Options

src/qt/locale/bitcoin_ky.ts

Loading...
View Options

src/qt/locale/bitcoin_la.ts

Loading...
View Options

src/qt/locale/bitcoin_lt.ts

Loading...
View Options

src/qt/locale/bitcoin_lv_LV.ts

Loading...
View Options

src/qt/locale/bitcoin_mk_MK.ts

Loading...
View Options

src/qt/locale/bitcoin_mn.ts

Loading...
View Options

src/qt/locale/bitcoin_ms_MY.ts

Loading...
View Options

src/qt/locale/bitcoin_nb.ts

Loading...
View Options

src/qt/locale/bitcoin_ne.ts

Loading...
View Options

src/qt/locale/bitcoin_nl.ts

Loading...
View Options

src/qt/locale/bitcoin_pam.ts

Loading...
View Options

src/qt/locale/bitcoin_pl.ts

Loading...
View Options

src/qt/locale/bitcoin_pt_BR.ts

Loading...
View Options

src/qt/locale/bitcoin_pt_PT.ts

Loading...
View Options

src/qt/locale/bitcoin_ro.ts

Loading...
View Options

src/qt/locale/bitcoin_ro_RO.ts

Loading...
View Options

src/qt/locale/bitcoin_ru.ts

Loading...
View Options

src/qt/locale/bitcoin_ru_RU.ts

Loading...
View Options

src/qt/locale/bitcoin_sk.ts

Loading...
View Options

src/qt/locale/bitcoin_sl_SI.ts

Loading...
View Options

src/qt/locale/bitcoin_sq.ts

Loading...
View Options

src/qt/locale/bitcoin_sr.ts

Loading...
View Options

src/qt/locale/bitcoin_sr@latin.ts

Loading...
View Options

src/qt/locale/bitcoin_sv.ts

Loading...
View Options

src/qt/locale/bitcoin_ta.ts

Loading...
View Options

src/qt/locale/bitcoin_th_TH.ts

Loading...
View Options

src/qt/locale/bitcoin_tr.ts

Loading...
View Options

src/qt/locale/bitcoin_uk.ts

Loading...
View Options

src/qt/locale/bitcoin_uz@Cyrl.ts

Loading...
View Options

src/qt/locale/bitcoin_vi_VN.ts

Loading...
View Options

src/qt/locale/bitcoin_zh.ts

Loading...
View Options

src/qt/locale/bitcoin_zh_CN.ts

Loading...
View Options

src/qt/locale/bitcoin_zh_HK.ts

Loading...
View Options

src/qt/locale/bitcoin_zh_TW.ts

Loading...