Page MenuHomePhabricator

Rename Bitcoin to Bitcoin Cash in GUI & translation files
AbandonedPublic

Authored by andychen on Apr 9 2018, 15:14.

Details

Reviewers
schancel
deadalnix
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Summary

Some of the Bitcoin words should be renamed to Bitcoin Cash, however words such as BicoinABC & BitcoinGUI should not.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature/rename_bitcoin_to_bitcoincash
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 2284
Build 2706: Bitcoin ABC Buildbot (legacy)
Build 2705: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Apr 9 2018, 15:14
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptApr 9 2018, 15:14
schancel retitled this revision from rename Bitcoin to Bitcoin Cash in GUI & translation files to Rename Bitcoin to Bitcoin Cash in GUI & translation files.
schancel edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 9 2018, 15:58
deadalnix requested changes to this revision.Apr 9 2018, 22:35
deadalnix added a subscriber: deadalnix.

This wasn't the code that was accepted, and for good reason (this breaks various translations).

This revision now requires changes to proceed.Apr 9 2018, 22:35

This wasn't the code that was accepted, and for good reason (this breaks various translations).

which translations, I can fix it.

"Enter a Bitcoin address" this translation is broken, trying to find more.

some of the Bitcoin should be replaced to Bitcoin Cash in gui cpp files.

schancel requested changes to this revision.Apr 10 2018, 01:12

Thank you for your effort on this. In order to make sure this commit is valuable and works, can you please make sure that you are updating the references to the translations at the same time that you fix the translations?

src/qt/locale/bitcoin_af.ts
65 ↗(On Diff #3463)

The reference to this translation does not seem to be updated?

313 ↗(On Diff #3463)

I'm not seeing where this is referenced in the code?

341 ↗(On Diff #3463)

This one also does not seem to be updated in the cpp files?

This revision now requires changes to proceed.Apr 10 2018, 01:12

modify 'These are your Bitcoin Cash addresses'

andychen marked an inline comment as done.

rename Bitcoin to Bitcoin Cash in cpp files work with translation

more translation found:

src/qt/editaddressdialog.cpp
src/qt/guiutil.cpp

src/qt/forms/ui_signverifymessagedialog.h (This is gitignored)

src/qt/locale/bitcoin_af.ts
65 ↗(On Diff #3463)

fixed.

313 ↗(On Diff #3463)

tr("Bitcoin") in 929 of bitconigui.cpp file, will be fixed

341 ↗(On Diff #3463)

fixed.

src/qt/guiutil.cpp
166 ↗(On Diff #3465)

Doesn't seem to be in the translations?

src/qt/locale/bitcoin_bg.ts
1139 ↗(On Diff #3465)

here it is

src/qt/locale/bitcoin_ca.ts
2068 ↗(On Diff #3465)

Where is the code that references this updated?

fix translation in 'Warning: Invalid Bitcoin Cash address'

src/qt/locale/bitcoin_ca.ts
2068 ↗(On Diff #3465)

fixed.

deadalnix requested changes to this revision.Apr 10 2018, 13:14

There was a diff that was accepted with a set of changes. If you want to do more, do other diffs.

This revision now requires changes to proceed.Apr 10 2018, 13:14

There was a diff that was accepted with a set of changes. If you want to do more, do other diffs.

so, we should not amend the diff even if it's not accepted yet?

I keep in touch with Shammah Chancellor in this Diff, and fix those stuff, and he told me that I can amend the diff to this commit.