Current implementation only logs. It gives us a scaffold to add the actual indexer.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABCc30b383e4bf0: [Chronik] Add minimal `chronik::Start` and `chronik::Stop` to init.cpp
- ninja
- ./src/bitcoind -regtest prints "Starting Chronik..." in the logs
- Ctrl+C to terminate bitcoind prints "Stopping Chronik..." in the logs
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chronik-start-chronik
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 19818 Build 39350: Build Diff lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-chronik · build-clang Build 39349: arc lint + arc unit
Event Timeline
| chronik/CMakeLists.txt | ||
|---|---|---|
| 81–85 ↗ | (On Diff #34524) | This is enough as the include dirs are transitive properties of the targets (if PUBLIC) so when you use target_link_libraries after that your target inherits the include dirs from the right linked targets |
| 91 ↗ | (On Diff #34524) | With the above patch this is not needed |
| chronik/chronik-cpp/chronik.cpp | ||
| 6 ↗ | (On Diff #34524) | Sort. This is also a hint that the linter doesn't run in this directory, you need to include it in the .arclint file. |
| 9 ↗ | (On Diff #34524) | Use [[maybe_unused]] attributes around the parameters to avoid warnings |
| chronik/chronik-cpp/chronik.h | ||
| 4 ↗ | (On Diff #34524) | You're missing the include guards, welcome to C/C++ |
| 6 ↗ | (On Diff #34524) | You can forward declare Config and NodeContext instead. |
| 9 ↗ | (On Diff #34524) | You probably want to use a chronik namespace rather than suffixing. That will likely be useful later anyway. |
| .arclint | ||
|---|---|---|
| 6 ↗ | (On Diff #34533) | There are more useful linters that you can enable |
| chronik/CMakeLists.txt | ||
| 81–84 ↗ | (On Diff #34533) | Align the PUBLIC or make it a one-liner |
| chronik/chronik-cpp/chronik.cpp | ||
| 8 ↗ | (On Diff #34533) | #include <chronik-cpp/chronik.h> |
| 12 ↗ | (On Diff #34533) | |
| chronik/chronik-cpp/chronik.h | ||
| 5 ↗ | (On Diff #34533) | BITCOIN_CHRONIK_CPP_CHRONIK_H |
| 8 ↗ | (On Diff #34533) | The whole point of the forward declaration is that you don't need it |
| 17 ↗ | (On Diff #34533) | |