Paths

Table of Contentst

Differential D11876

[Cashtab] Convert `balance` to string throughout app
ClosedPublic
Actions

Authored by bytesofman on Aug 18 2022, 21:53.

Details

Reviewers

kieran709

Group Reviewers

Restricted Project

Commits

rABC699427a1af8d: [Cashtab] Convert `balance` to string throughout app

Summary

T2600

Depends on D11875

Test Plan

npm test

npm start and confirm app functions as before:

Check the XEC and fiat balance displays on every screen and verify they match cashtab.com

Diff Detail

Repository

rABC Bitcoin ABC

Branch

return-bignumber-fromsatstoxec

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 19856
Build 39426: Build Diff	cashtab-tests
Build 39425: arc lint + arc unit

Event Timeline

bytesofman created this revision.Aug 18 2022, 21:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 18 2022, 21:53

bytesofman requested review of this revision.Aug 18 2022, 21:53

Harbormaster completed remote builds in B19856: Diff 34711.Aug 18 2022, 21:56

kieran709 accepted this revision.Aug 22 2022, 23:13

This revision is now accepted and ready to land.Aug 22 2022, 23:13

Closed by commit rABC699427a1af8d: [Cashtab] Convert `balance` to string throughout app (authored by bytesofman). · Explain WhyAug 22 2022, 23:41

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC699427a1af8d: [Cashtab] Convert `balance` to string throughout app.

Revision Contents
Changeset List

Path

Size

web/

cashtab/

src/

components/

Common/

BalanceHeader.js

4 lines

BalanceHeaderFiat.js

7 lines

Home/

__mocks__/

walletAndBalancesMock.js

Tokens/

Tokens.js

11 lines

__tests__/

CreateTokenForm.test.js

9 lines

utils/

__mocks__/

mockCachedUtxos.js

mockStoredWallets.js

4 lines

cashMethods.js

9 lines

Diff 34711

View Options

web/cashtab/src/components/Common/BalanceHeader.js

View Options

web/cashtab/src/components/Common/BalanceHeaderFiat.js

View Options

web/cashtab/src/components/Home/mocks/walletAndBalancesMock.js

View Options

web/cashtab/src/components/Tokens/Tokens.js

View Options

web/cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

View Options

web/cashtab/src/utils/mocks/mockCachedUtxos.js

View Options

web/cashtab/src/utils/mocks/mockStoredWallets.js

View Options

web/cashtab/src/utils/cashMethods.js

[Cashtab] Convert `balance` to string throughout appClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34711

web/cashtab/src/components/Common/BalanceHeader.js

web/cashtab/src/components/Common/BalanceHeaderFiat.js

web/cashtab/src/components/Home/__mocks__/walletAndBalancesMock.js

web/cashtab/src/components/Tokens/Tokens.js

web/cashtab/src/components/Tokens/__tests__/CreateTokenForm.test.js

web/cashtab/src/utils/__mocks__/mockCachedUtxos.js

web/cashtab/src/utils/__mocks__/mockStoredWallets.js

web/cashtab/src/utils/cashMethods.js

[Cashtab] Convert `balance` to string throughout app
ClosedPublic
Actions

Revision Contents
Changeset List

web/cashtab/src/components/Home/mocks/walletAndBalancesMock.js

web/cashtab/src/components/Tokens/tests/CreateTokenForm.test.js

web/cashtab/src/utils/mocks/mockCachedUtxos.js

web/cashtab/src/utils/mocks/mockStoredWallets.js