Page MenuHomePhabricator

[Cashtab-components] Upgrade storybook by running npx sb upgrade
ClosedPublic

Authored by bytesofman on Aug 31 2022, 21:07.

Details

Summary

T2634

Upgrading storybook as a pre-req to successfully running npm upgrade, which otherwise fails due to peer deps

Interesting to note that upgrading storybook per their recommended procedure --- running npx sb upgrade --- simply adds a .npmrc file with legacy-peer-deps=true ... which is not really a 'solution' for this problem. Interesting JS practices even at a module with over 3 million downloads per week.

Test Plan

npm run storybook and note display loads with no errors
npm run build and no errors

Diff Detail

Repository
rABC Bitcoin ABC
Branch
components-deps-upgrade
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19908
Build 39523: Build Diffcashtab-components-tests
Build 39522: arc lint + arc unit