Page MenuHomePhabricator
Differential D11918

[avalanche] Use sane default for the quorum minimum connected stake ratio
ClosedPublic
Actions

Authored by Fabien on Sep 6 2022, 11:37.

Details

Reviewers
PiRK
sdulfari
Group Reviewers
Restricted Project
Commits
rABC6cdfe9a382e6: [avalanche] Use sane default for the quorum minimum connected stake ratio
Summary

Similar to D11917, update the last remaining non compatible tests with an option override and make the sane value the default.

Depends on D11917.

Test Plan
ninja all check-extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
avalanche_quorum_stake_ratio_default
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 19943
Build 39592: Build Difflint-circular-dependencies · build-diff · build-clang-tidy · build-without-wallet · build-clang · build-debug
Build 39591: arc lint + arc unit

Event Timeline

Fabien created this revision.Sep 6 2022, 11:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 6 2022, 11:37
Fabien requested review of this revision.Sep 6 2022, 11:37
Harbormaster completed remote builds in B19932: Diff 34821.Sep 6 2022, 12:00
Fabien added a child revision: D11919: [avalanche] Use sane default for the minimum number of nodes that sent compact proofs.Sep 6 2022, 12:47
PiRK accepted this revision.Sep 6 2022, 14:01
This revision is now accepted and ready to land.Sep 6 2022, 14:01
sdulfari requested changes to this revision.Sep 6 2022, 16:20
sdulfari added a subscriber: sdulfari.
sdulfari added inline comments.
src/avalanche/avalanche.h
64 ↗(On Diff #34821)

Cleanup comment

This revision now requires changes to proceed.Sep 6 2022, 16:20
Fabien updated this revision to Diff 34837.Sep 6 2022, 18:57

Fix comment

Harbormaster completed remote builds in B19943: Diff 34837.Sep 6 2022, 19:14
sdulfari accepted this revision.Sep 6 2022, 23:32
This revision is now accepted and ready to land.Sep 6 2022, 23:32
Closed by commit rABC6cdfe9a382e6: [avalanche] Use sane default for the quorum minimum connected stake ratio (authored by Fabien). · Explain WhySep 7 2022, 09:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6cdfe9a382e6: [avalanche] Use sane default for the quorum minimum connected stake ratio.

Revision Contents
Changeset List

PathSize
src/
avalanche/
6 lines
test/
7 lines
3 lines
5 lines

Diff 34837

View Options

src/avalanche/avalanche.h

Loading...
View Options

src/avalanche/test/init_tests.cpp

Loading...
View Options

src/avalanche/test/processor_tests.cpp

Loading...
View Options

src/init.cpp

Loading...